fixed a bug on starting remote server have no path at all #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a bug here,
the process should like this.
1.fire up a remote node for nif function calling by calling a Anonymous fun,
2.It start to receive Path and fix the path
3.fire slave_listen for incoming rpc call.
The process is okay,but the first step, when firing up the child process, child process doesn't have any path info, and the anonymous function is being wrapped in nifty_remotecall module, and then when start firing up the child server, child server crashes here, it won't have any information about the module at the time.
I've used erl_eval to wrap the anonymous func now(which replaced slave_listen/0, and then exposed slave_listen/1 to the outside, now the remote part works like expected.
Really appreciate for this lib, it really helps me a lot on generating nif codes, but still, can we improve the code quality which it generated by the template? I'm seeing a lot of blanks in generated c file, which is really annoying for error detect here.
Thx for your hard work, hope it can become better in the near future ;)