Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix --functional progress output #828

Merged
merged 10 commits into from
Feb 19, 2024
Merged

Fix --functional progress output #828

merged 10 commits into from
Feb 19, 2024

Conversation

ax-ml
Copy link
Contributor

@ax-ml ax-ml commented Dec 21, 2023 •
edited
Loading

Fix #826

@ax-ml ax-ml marked this pull request as draft December 22, 2023 17:15
@ax-ml ax-ml marked this pull request as ready for review December 22, 2023 17:28
@Slamdunk Slamdunk mentioned this pull request Feb 10, 2024
Closed
@ax-ml ax-ml marked this pull request as draft February 12, 2024 16:32
@ax-ml ax-ml marked this pull request as ready for review February 12, 2024 16:55
@ax-ml ax-ml requested review from Slamdunk and deluxetom February 12, 2024 16:56
Slamdunk
Slamdunk requested changes Feb 19, 2024
View reviewed changes
Copy link
Member

@Slamdunk Slamdunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to revert src/WrapperRunner/SuiteLoader.php to the 7.x branch, and the test in this PR still succeed, this means that the changes are not tested.

Could you please prove the bug with a failing test? Otherwise the risk to re-introduce it in the future is very high.

@ax-ml ax-ml requested a review from Slamdunk February 19, 2024 14:34
@Slamdunk Slamdunk added the bug label Feb 19, 2024
@Slamdunk Slamdunk changed the title Add filter regex name Fix --functional progress output Feb 19, 2024
@Slamdunk Slamdunk merged commit cf4e141 into paratestphp:7.x Feb 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Slamdunk Slamdunk Slamdunk approved these changes

@deluxetom deluxetom Awaiting requested review from deluxetom

Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad progress output with option --functional
3 participants
@ax-ml @Slamdunk @deluxetom