This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Integrate a governance XCM origin #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
changed the title
apopiak
reviewed
Apr 16, 2021
|
So when we try something similar in statemint the message doesn't seem to be handled correctly (I'm still figuring out how to debug this better.), but I have a guess at where this is failing: Cumulus handles downward messages here by giving them the Edit: I missed that the message will be wrapped in |
|
|
||
| // After hashing each message in the message queue chain submitted by the collator, we should | ||
| // arrive to the MQC head provided by the relay chain. | ||
| assert_eq!(result_mqc_head, expected_dmq_mqc_head); |
There was a problem hiding this comment.
we could put this above the deposit event and then avoid the clone?
There was a problem hiding this comment.
yeah - it was relying on an indirect panic before. this just makes it explicit.
There was a problem hiding this comment.
also done in this PR: #413
apopiak
reviewed
Apr 28, 2021
|
@apopiak @shawntabrizi approvals? |
apopiak
approved these changes
Apr 28, 2021
This was referenced May 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.