Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Add sysctl ipv6 and extra CI steps #63

Merged
merged 24 commits into from
Mar 20, 2024
Merged

Conversation

lexnv
Copy link
Collaborator

@lexnv lexnv commented Mar 18, 2024

Changes the binding in response to

CI steps that are running now:

  • cargo fmt
  • cargo machete for unused dependencies (has detected one)
  • cargo check
  • cargo doc (with extra checks)
  • cargo clippy
  • cargo test

While at it, I've also fixed cargo doc tests.

I've added reorder_imports (similar to Substrate) to group imports from the same crate.

At the time being, the clippy step is allowed to fail to not block this PR further and a proper fix should land with: #57.

Builds on #56

Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv lexnv self-assigned this Mar 18, 2024
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv lexnv mentioned this pull request Mar 18, 2024
@dmitry-markin
Copy link
Collaborator

@lexnv Do you think we should keep both --sysctl IPv6 fix and binding to IPv4 addresses?

@lexnv
Copy link
Collaborator Author

lexnv commented Mar 19, 2024

I think we could keep the sysctl fix, I'll revert my binding changes, good point thanks!

lexnv added 16 commits March 19, 2024 17:53
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
@lexnv
Copy link
Collaborator Author

lexnv commented Mar 19, 2024

@dmitry-markin Let me know what you think of it, since I've change quite a few things.

CI steps that are running now:

  • cargo fmt
  • cargo machete for unused dependencies (has detected one)
  • cargo check
  • cargo doc (with extra checks)
  • cargo clippy
  • cargo test

While at it, I've also fixed cargo doc tests.

I've added reorder_imports (similar to Substrate) to group imports from the same crate.
Since these are quite opinionated, would love to get your input on them, we could otherwise revert the parts you think are unnecessary / too restrictive 🙏

At the moment, the clippy step is allowed to fail to not block this PR further and a proper fix should land with: #57.

@lexnv lexnv changed the title tests: Use ipv4 local addr tests: Add sysctl ipv6 and extra CI steps Mar 19, 2024
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@dmitry-markin
Copy link
Collaborator

I've added reorder_imports (similar to Substrate) to group imports from the same crate.
Since these are quite opinionated, would love to get your input on them, we could otherwise revert the parts you think are unnecessary / too restrictive 🙏

Makes sense to me. Overall, you changes seem to be a big improvement, thank you!

One thing I don't understand / don't know how to check are all that github CI actions like:

uses: "andymckay/cancel-action@271cfbfa11ca9222f7be99a47e8f929574549e0a"

Not sure, how do we select the audited/trusted ones? (But may be if they work that's all we need to know.)

.github/workflows/ci.yml Outdated Show resolved Hide resolved
lexnv and others added 2 commits March 20, 2024 11:46
Co-authored-by: Alexander Samusev <[email protected]>
@lexnv lexnv merged commit 25674bf into as-ci Mar 20, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants