-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: Add sysctl ipv6 and extra CI steps #63
Conversation
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Co-authored-by: Alexander Samusev <[email protected]>
@lexnv Do you think we should keep both |
I think we could keep the |
This reverts commit 1e16a28.
This reverts commit 32ea0ca.
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
@dmitry-markin Let me know what you think of it, since I've change quite a few things. CI steps that are running now:
While at it, I've also fixed cargo doc tests. I've added At the moment, the clippy step is allowed to fail to not block this PR further and a proper fix should land with: #57. |
Makes sense to me. Overall, you changes seem to be a big improvement, thank you! One thing I don't understand / don't know how to check are all that github CI actions like:
Not sure, how do we select the audited/trusted ones? (But may be if they work that's all we need to know.) |
Co-authored-by: Alexander Samusev <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Changes the binding in response to
localhost
inside a container fails because ::1 doesn't exist docker/for-linux#1374This is achieved via
--sysctl net.ipv6.conf.all.disable_ipv6=0
CI steps that are running now:
While at it, I've also fixed cargo doc tests.
I've added
reorder_imports
(similar to Substrate) to group imports from the same crate.At the time being, the clippy step is allowed to fail to not block this PR further and a proper fix should land with: #57.
Builds on #56