Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor pallets to V2 bench syntax #6202

Open
5 of 43 tasks
ggwpez opened this issue Oct 23, 2024 · 10 comments
Open
5 of 43 tasks

Refactor pallets to V2 bench syntax #6202

ggwpez opened this issue Oct 23, 2024 · 10 comments
Labels
C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I4-refactor Code needs refactoring. T12-benchmarks This PR/Issue is related to benchmarking and weights.

Comments

@ggwpez
Copy link
Member

ggwpez commented Oct 23, 2024 •
edited
Loading

We should move all remaining pallets to the V2 benchmarking syntax. It seems to be stable and feature complete.

👉 If you want to work on this: Please check that there is not already a merge request for the pallet that you want to work on. Please pick only one or a small set of pallets - not all at once. This keeps review times low.

Full pallet list:

Then the Polkadot and Cumulus pallets:

  • ./cumulus/pallets/session-benchmarking/src/inner.rs
  • ./polkadot/xcm/pallet-xcm-benchmarks/src/generic/benchmarking.rs
  • ./polkadot/xcm/pallet-xcm/src/benchmarking.rs
  • ./polkadot/runtime/common/src/claims.rs
  • ./polkadot/runtime/common/src/crowdloan/mod.rs
  • ./polkadot/runtime/common/src/paras_registrar/mod.rs
  • ./polkadot/runtime/common/src/auctions.rs
  • ./polkadot/runtime/common/src/slots/mod.rs
  • ./polkadot/runtime/parachains/src/initializer/benchmarking.rs
  • ./polkadot/runtime/parachains/src/configuration/benchmarking.rs
  • ./polkadot/runtime/parachains/src/paras_inherent/benchmarking.rs
  • ./polkadot/runtime/parachains/src/inclusion/benchmarking.rs
  • ./polkadot/runtime/parachains/src/disputes/benchmarking.rs
  • ./polkadot/runtime/parachains/src/disputes/slashing/benchmarking.rs
  • ./polkadot/runtime/parachains/src/paras/benchmarking.rs
@ggwpez ggwpez added I4-refactor Code needs refactoring. T12-benchmarks This PR/Issue is related to benchmarking and weights. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. labels Oct 23, 2024
@ggwpez ggwpez changed the title Migrate all pallets to benchmarking V2 syntax Refactor pallets to V2 bench syntax Oct 23, 2024
@ggwpez ggwpez mentioned this issue Oct 23, 2024
Open
@AurevoirXavier
Copy link
Contributor

AurevoirXavier commented Oct 28, 2024 •
edited
Loading

Some updates:

This was referenced Oct 28, 2024
Merged
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 29, 2024
@AurevoirXavier
Migrate pallet-vesting benchmark to v2 (#6254)
1497635 
Part of:

- #6202.
github-merge-queue bot pushed a commit that referenced this issue Oct 29, 2024
@AurevoirXavier @seadanda
Migrate pallet-timestamp benchmark to v2 (#6258)
80cd5fd 
Part of:

- #6202

---------

Co-authored-by: Dónal Murray <[email protected]>
This was referenced Oct 29, 2024
Merged
Open
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 29, 2024
@AurevoirXavier @mordamax
Migrate pallet-vesting benchmark to v2 (paritytech#6254)
1819d89 
Part of:

- paritytech#6202.
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 29, 2024
@AurevoirXavier @seadanda @mordamax
Migrate pallet-timestamp benchmark to v2 (paritytech#6258)
dee9777 
Part of:

- paritytech#6202

---------

Co-authored-by: Dónal Murray <[email protected]>
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 29, 2024
@AurevoirXavier @mordamax
Migrate pallet-vesting benchmark to v2 (paritytech#6254)
65ee481 
Part of:

- paritytech#6202.
mordamax pushed a commit to paritytech-stg/polkadot-sdk that referenced this issue Oct 29, 2024
@AurevoirXavier @seadanda @mordamax
Migrate pallet-timestamp benchmark to v2 (paritytech#6258)
b41419a 
Part of:

- paritytech#6202

---------

Co-authored-by: Dónal Murray <[email protected]>
@programskillforverification
Copy link
Contributor

programskillforverification commented Oct 30, 2024 •
edited
Loading

Pick up:

  • transaction-storage, indices
  • babe, child-bounties, democracy
  • fast-unstake

github-merge-queue bot pushed a commit that referenced this issue Oct 30, 2024
@AurevoirXavier @seadanda
Migrate pallet-utility to benchmark v2 (#6276)
06debd0 
Part of:

- #6202.

---------

Co-authored-by: Dónal Murray <[email protected]>
@clangenb
Copy link
Contributor

clangenb commented Oct 30, 2024 •
edited
Loading

Pickup:

  • pallet-remark, pallet-scheduler

@AurevoirXavier
Copy link
Contributor

Pickup:

  • pallet-remark, pallet-scheduler

Hi, I'm working scheduler currently. :)

@clangenb
Copy link
Contributor

Thanks for the quick response 🚀

Open
@clangenb clangenb mentioned this issue Oct 30, 2024
Open
@clangenb
Copy link
Contributor

Pickup:

  • pallet-sessions
  • pallet-recovery
  • pallet-offences

@AurevoirXavier
Copy link
Contributor

Pick up:

  • transaction-storage, indices
  • babe, child-bounties, democracy
  • fast-unstake, glutton

Well... I recommend handling them individually and providing updates here, rather than claiming them all at once.

This was referenced Oct 30, 2024
Open
Open
@clangenb clangenb mentioned this issue Oct 30, 2024
Open
@AurevoirXavier AurevoirXavier mentioned this issue Oct 30, 2024
Open
@AurevoirXavier AurevoirXavier mentioned this issue Oct 30, 2024
Open
@programskillforverification
Copy link
Contributor

Pick up:

  • transaction-storage, indices
  • babe, child-bounties, democracy
  • fast-unstake, glutton

Well... I recommend handling them individually and providing updates here, rather than claiming them all at once.

If so, we have to create many pr, that's a little tedious, and this page will extend too long

@AurevoirXavier
Copy link
Contributor

If so, we have to create many pr, that's a little tedious, and this page will extend too long

That's why there is a summary on the top.

And this makes easier to collaborate with others.

But the most important reason is:

One PR for one task = Easy review

This was referenced Oct 30, 2024
Open
Open
@clangenb
Copy link
Contributor

Pickup:

  • pallet-nomination-pools
  • pallet-nft-fractionalization

This was referenced Oct 30, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C2-good-first-issue A task for a first time contributor to become familiar with the Polkadot-SDK. D0-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder. I4-refactor Code needs refactoring. T12-benchmarks This PR/Issue is related to benchmarking and weights.
Projects
Runtime / FRAME
Status: Backlog
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ggwpez @AurevoirXavier @clangenb @programskillforverification