migrate pallet-recovery to benchmark V2 syntax #6299
+73
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 tasks
ggwpez
reviewed
Oct 30, 2024
| } | ||
|
|
||
| cancel_recovered { | ||
| #[benchmark] | ||
| fn cancel_recovered() -> Result<(), BenchmarkError> { |
There was a problem hiding this comment.
I think if you dont use a ? then you can also remove the return type and just return ().
There was a problem hiding this comment.
I just preserved the previous behavior, but happy to change it. I was wondering if there is any good use for BenchmarkError at all.
ggwpez
approved these changes
Oct 30, 2024
|
/cmd prdoc --bump patch --audience runtime_dev |
ggwpez
added
T2-pallets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of: