Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make vscode rustanalyzer fast again #4470

Merged
merged 3 commits into from
May 15, 2024
Merged

Make vscode rustanalyzer fast again #4470

merged 3 commits into from
May 15, 2024

Conversation

alexggh
Copy link
Contributor

@alexggh alexggh commented May 15, 2024

This bump of versions:
https://github.com/paritytech/polkadot-sdk/pull/4409/files#diff-13ee4b2252c9e516a0547f2891aa2105c3ca71c6d7a1e682c69be97998dfc87eR11936

reintroduced a dependency to proc-macro-crate 2.0.0 which is suffering from: bkchr/proc-macro-crate#42 this, so bump parity-scale-codec to a newer version to eliminate the bad proc-macro-crate 2.0.0 dependency.

@alexggh
Mak vscode rustanalyzer fast again
214b964 
This bump of versions:
https://github.com/paritytech/polkadot-sdk/pull/4409/files#diff-13ee4b2252c9e516a0547f2891aa2105c3ca71c6d7a1e682c69be97998dfc87eR11936

reintroduced a dependency to proc-macro-crate 2.0.0 which is suffering
from: bkchr/proc-macro-crate#42 this, so bump
parity-scale-codec to a newer version to eliminate the 2.0.0 dependency.

Signed-off-by: Alexandru Gheorghe <[email protected]>
@alexggh alexggh requested a review from tdimitrov May 15, 2024 13:24
@alexggh alexggh changed the title Mak vscode rustanalyzer fast again Make vscode rustanalyzer fast again May 15, 2024
@alexggh alexggh requested a review from alindima May 15, 2024 13:27
@alexggh alexggh added the R0-silent Changes should not be mentioned in any release notes label May 15, 2024
@alexggh alexggh enabled auto-merge May 15, 2024 13:42
@alexggh alexggh disabled auto-merge May 15, 2024 14:06
@tdimitrov
Copy link
Contributor

bot update-ui

@command-bot
Copy link

command-bot bot commented May 15, 2024 •
edited
Loading

@tdimitrov https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6210409 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-40eb7e9b-8908-4e19-b3dd-673b4ba88cfa to cancel this command or bot cancel to cancel all commands in this pull request.

bkchr
bkchr requested changes May 15, 2024
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump the parity-scale-codec dependency in the Cargo.toml files that this doesn't happen again.

@alexggh alexggh requested a review from a team as a code owner May 15, 2024 15:00
@command-bot
Copy link

command-bot bot commented May 15, 2024

@tdimitrov Command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6210409 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6210409/artifacts/download.

@alexggh
Bump parity-scale-codec to 3.6.12 everywhere
14327d0 
... change should not have any impact because Cargo.lock is already
updated.

Signed-off-by: Alexandru Gheorghe <[email protected]>
@paritytech-review-bot paritytech-review-bot bot requested a review from a team May 15, 2024 15:10
@alexggh
Copy link
Contributor Author

alexggh commented May 15, 2024 •
edited
Loading

Please bump the parity-scale-codec dependency in the Cargo.toml files that this doesn't happen again.

Bumped parity-scale-code everywhere to 3.6.12, there were some places where the version was quite old, but I don't think there is any impact, because they were using already what we had in the Cargo.lock.

bkchr
bkchr approved these changes May 15, 2024
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!

@bkchr
Copy link
Member

bkchr commented May 15, 2024

Bumped parity-scale-code everywhere to 3.6.12, there were some places where the version was quite old, but I don't think there is any impact, because they were using already what we had in the Cargo.lock.

Yes, cargo unifies across the same major version.

@bkchr bkchr enabled auto-merge May 15, 2024 15:27
@bkchr bkchr added this pull request to the merge queue May 15, 2024
Merged via the queue into master with commit e31fcff May 15, 2024
161 of 163 checks passed
@bkchr bkchr deleted the alexaghh/bump_scale_codec branch May 15, 2024 16:31
hitchhooker pushed a commit to ibp-network/polkadot-sdk that referenced this pull request Jun 5, 2024
@alexggh @hitchhooker
Make vscode rustanalyzer fast again (paritytech#4470)
e0a9464 
This bump of versions:

https://github.com/paritytech/polkadot-sdk/pull/4409/files#diff-13ee4b2252c9e516a0547f2891aa2105c3ca71c6d7a1e682c69be97998dfc87eR11936

reintroduced a dependency to proc-macro-crate 2.0.0 which is suffering
from: bkchr/proc-macro-crate#42 this, so bump
parity-scale-codec to a newer version to eliminate the bad
proc-macro-crate 2.0.0 dependency.

---------

Signed-off-by: Alexandru Gheorghe <[email protected]>
Co-authored-by: command-bot <>
liuchengxu pushed a commit to liuchengxu/polkadot-sdk that referenced this pull request Jun 19, 2024
@alexggh @liuchengxu
Make vscode rustanalyzer fast again (paritytech#4470)
defa771 
This bump of versions:

https://github.com/paritytech/polkadot-sdk/pull/4409/files#diff-13ee4b2252c9e516a0547f2891aa2105c3ca71c6d7a1e682c69be97998dfc87eR11936

reintroduced a dependency to proc-macro-crate 2.0.0 which is suffering
from: bkchr/proc-macro-crate#42 this, so bump
parity-scale-codec to a newer version to eliminate the bad
proc-macro-crate 2.0.0 dependency.

---------

Signed-off-by: Alexandru Gheorghe <[email protected]>
Co-authored-by: command-bot <>
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
@alexggh @TarekkMA
Make vscode rustanalyzer fast again (paritytech#4470)
a5e0cb9 
This bump of versions:

https://github.com/paritytech/polkadot-sdk/pull/4409/files#diff-13ee4b2252c9e516a0547f2891aa2105c3ca71c6d7a1e682c69be97998dfc87eR11936

reintroduced a dependency to proc-macro-crate 2.0.0 which is suffering
from: bkchr/proc-macro-crate#42 this, so bump
parity-scale-codec to a newer version to eliminate the bad
proc-macro-crate 2.0.0 dependency.

---------

Signed-off-by: Alexandru Gheorghe <[email protected]>
Co-authored-by: command-bot <>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdimitrov tdimitrov tdimitrov approved these changes

@bkchr bkchr bkchr approved these changes

@acatangiu acatangiu acatangiu approved these changes

@athei athei Awaiting requested review from athei

@sorpaas sorpaas Awaiting requested review from sorpaas sorpaas is a code owner

@andresilva andresilva Awaiting requested review from andresilva

@cheme cheme Awaiting requested review from cheme cheme is a code owner

@koute koute Awaiting requested review from koute koute is a code owner

@alindima alindima Awaiting requested review from alindima

@ggwpez ggwpez Awaiting requested review from ggwpez

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexggh @tdimitrov @bkchr @ggwpez @alindima @acatangiu