Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix semver job by updating cargo toolchain #6283

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

skunert
Copy link
Contributor

@skunert skunert commented Oct 30, 2024

Changes here #6254 broke the semver job: https://github.com/paritytech/polkadot-sdk/actions/runs/11590030127/job/32266861391?pr=5891

Because it is using an old nightly without PanicHookInfo. Attempting to fix this by changing to stable. We can also use newer nightly, but reasons for nightly are unclear to me currently.

@skunert skunert added the R0-silent Changes should not be mentioned in any release notes label Oct 30, 2024
@skunert skunert requested review from a team as code owners October 30, 2024 09:51
@paritytech-review-bot paritytech-review-bot bot requested a review from a team October 30, 2024 10:03
workflow_dispatch:

concurrency:
group: check-semver-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: true

env:
TOOLCHAIN: nightly-2024-06-01
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We needed to lock this to a specific nightly since the https://github.com/paritytech/parity-publish only supports a specific version.
Not sure if this will still work now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm so there is a mapping between parity-publish and supported nightly? Disabled merge for now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea it uses some docs export feature from nighly, but it reads like the newest version can also handle stable: https://github.com/obi1kenobi/cargo-semver-checks/releases/tag/v0.36.0#:~:text=all%20stable%20Rust%20versions
Just need to update our parity tool.

@skunert skunert disabled auto-merge October 30, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants