Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename project to polkadot-staking-miner #717

Merged
merged 5 commits into from
Nov 27, 2023

Conversation

niklasad1
Copy link
Member

@niklasad1 niklasad1 commented Nov 23, 2023

We have reserved polkadot-staking-miner on crates.io because staking-miner was reserved already.

To able to publish the binary to crates.io then this project has to renamed to polkadot-staking-miner is that okay?
We could keep binary name to staking-miner but I think that is confusing, so all good to call it "polkadot-staking-miner"?

Close #680

version = "1.2.0"
authors = ["Parity Technologies <[email protected]>"]
edition = "2021"
rust-version = "1.70.0"
license = "GPL-3.0"
repository = "https://github.com/paritytech/polkadot-staking-miner"
Copy link
Member Author

@niklasad1 niklasad1 Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change this repo name as well if we agree :)

@@ -126,7 +126,7 @@ it's possible build the polkadot binary with `feature --fast-runtime`
to ensure that elections occurs more often (in order of minutes rather hours/days).

```bash
$ cargo run --release --package polkadot --features fast-runtime -- --chain polkadot-dev --tmp --alice --execution Native -lruntime=debug --offchain-worker=Never --ws-port 9999
$ cargo run --release --package polkadot --features fast-runtime -- --chain westend-dev --tmp --alice --execution Native -lruntime=debug --offchain-worker=Never --ws-port 9999
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

polkadot-dev is removed nowdays

RELEASE-CHECKLIST.md Outdated Show resolved Hide resolved
@@ -176,5 +176,4 @@ staking_miner_submit_and_watch_duration_ms 17283

## Related projects

- [polkadot staking miner](https://github.com/paritytech/polkadot/tree/master/utils/staking-miner) - provides similar functionality but each release is hard-coded to a specific runtime version
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is removed as well.

Copy link
Contributor

@gpestana gpestana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming the repo and binary to polkadot-staking-miner sounds good to me.

@niklasad1 niklasad1 merged commit 1f5e5a8 into main Nov 27, 2023
9 checks passed
@niklasad1 niklasad1 deleted the rename-project-to-polkadot-staking-miner branch November 27, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

publish binary to crates.io
2 participants