Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update example to Parse Server 8 #562

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

dblythy
Copy link
Member

@dblythy dblythy commented Jan 13, 2025

Closes: #558
Closes: #398
Closes: #396
Closes: #399

Copy link

I will reformat the title to use the proper commit message syntax.

@parse-github-assistant parse-github-assistant bot changed the title feat: update example feat: Update example Jan 13, 2025
Copy link

parse-github-assistant bot commented Jan 13, 2025

Thanks for opening this pull request!

@mtrezza
Copy link
Member

mtrezza commented Jan 13, 2025

Which issue does this PR close? Is it #558?

@dblythy
Copy link
Member Author

dblythy commented Jan 13, 2025

Yes sorry

@mtrezza mtrezza changed the title feat: Update example feat: Update example to Parse Server 8 Jan 13, 2025
@dblythy
Copy link
Member Author

dblythy commented Jan 14, 2025

Some QOL improvements here:

  • using ESM
  • using the JS SDK in the demo file
  • presenting an opinionated folder structure and class design that should allow for better testability
  • adding unit tests that can run very fast and in parallel
  • simplification of the CI - no need to have multiple node versions

@mtrezza
Copy link
Member

mtrezza commented Jan 16, 2025

Great work, just about these:

  • presenting an opinionated folder structure and class design that should allow for better testability
  • adding unit tests that can run very fast and in parallel

I appreciate the approach to apply a theoretical best-practice, but for this simple repo it seems a bit much. We want to keep this repo as slim as possible to demo Parse Server in a light weight, few dependencies, low maintenance repo.

Parallel testing, new test framework with jest, etc. are out of scope; we want to avoid that at some point in the future we have to spend time fixing this, as it's not the purpose of this repo. Could you please keep the structure and nomenclature we are currently using across most repos (/spec) and remove the subfolders "Hello", etc. Just a test file with the same name as the file that is being tested should provide enough overview, e.g. /spec/TestObject.spec.js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants