-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update example to Parse Server 8 #562
base: master
Are you sure you want to change the base?
Conversation
I will reformat the title to use the proper commit message syntax. |
Thanks for opening this pull request! |
Which issue does this PR close? Is it #558? |
Yes sorry |
Some QOL improvements here:
|
Great work, just about these:
I appreciate the approach to apply a theoretical best-practice, but for this simple repo it seems a bit much. We want to keep this repo as slim as possible to demo Parse Server in a light weight, few dependencies, low maintenance repo. Parallel testing, new test framework with jest, etc. are out of scope; we want to avoid that at some point in the future we have to spend time fixing this, as it's not the purpose of this repo. Could you please keep the structure and nomenclature we are currently using across most repos (/spec) and remove the subfolders "Hello", etc. Just a test file with the same name as the file that is being tested should provide enough overview, e.g. |
Closes: #558
Closes: #398
Closes: #396
Closes: #399