Add support for push time #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 78.33% (diff: 66.66%)@@ master #22 diff @@
==========================================
Files 1 1
Lines 114 120 +6
Methods 9 9
Messages 0 0
Branches 18 20 +2
==========================================
+ Hits 90 94 +4
- Misses 24 26 +2
Partials 0 0
|
|
Would appreciate any feedback on this. Thanks! |
|
This was not working for me. I added 5 minute to the push time but the push went right away. But the weird part is the logs showed that the 5 minutes were added as a scheduled push but the actual pushStatus said the current time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds basic support for push time for sending scheduled notifications. Would appreciate any feedback around how best to capture this in the test cases.