-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
phpbench: added github action to perf compare PR changes against the main-branch #37
Open
staabm
wants to merge
33
commits into
parsica-php:main
Choose a base branch
from
staabm:gh-bench
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
staabm
commented
Mar 14, 2021
•
edited
Loading
edited
- a github action runs on new pull request
- the action will run the benchmark against the main branch and afterwards within the same instance check out the pull request contents and run the benchmark a second time -> a perf diff will be generated
- the resulting perf diff will be posted as a comment by the github action
- on followup commits the initial comment will be updated with a updated perf diff
staabm
commented
Mar 14, 2021
✔️ |
staabm
changed the title
phpbench: added composer scripts for recording/comparing a baseline
phpbench: added github action to perf compare PR changes against the main-branch
Mar 14, 2021
blocked by another upstream issue: peter-evans/create-or-update-comment#76 |
I guess this is ready to go. Whether this works like expected can only be tested after it was merged. expected behaviour is
#38 needs to be merged first as a preparation |
staabm
commented
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.