Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phpbench: added github action to perf compare PR changes against the main-branch #37

Open
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Mar 14, 2021

  • a github action runs on new pull request
  • the action will run the benchmark against the main branch and afterwards within the same instance check out the pull request contents and run the benchmark a second time -> a perf diff will be generated
  • the resulting perf diff will be posted as a comment by the github action
  • on followup commits the initial comment will be updated with a updated perf diff

@staabm
Copy link
Contributor Author

staabm commented Mar 14, 2021

blocked on upstream issue phpbench/phpbench#764

✔️

@staabm staabm changed the title phpbench: added composer scripts for recording/comparing a baseline phpbench: added github action to perf compare PR changes against the main-branch Mar 14, 2021
@staabm
Copy link
Contributor Author

staabm commented Mar 15, 2021

blocked by another upstream issue: peter-evans/create-or-update-comment#76

@staabm
Copy link
Contributor Author

staabm commented Mar 16, 2021

I guess this is ready to go. Whether this works like expected can only be tested after it was merged.

expected behaviour is

  • a github action runs on new pull request
  • the action will run the benchmark against the main branch and afterwards within the same instance check out the pull request contents and run the benchmark a second time -> a perf diff will be generated
  • the resulting perf diff will be posted as a comment by the github action
  • on followup commits the initial comment will be updated with a updated perf diff

#38 needs to be merged first as a preparation

@staabm staabm marked this pull request as ready for review March 16, 2021 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant