Show progress bar when flashing Tachyon #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Show progress bar while flashing - Show location of output log file at the start of the flashing process. - Throw error is device is not in EDL mode or no device is detected. - Propagate any errors
monkbroc
approved these changes
Jan 16, 2025
src/lib/qdl.js
Outdated
| const qdlArgs = [ | ||
| '--storage', | ||
| TACHYON_STORAGE_TYPE, | ||
| async function run({ files, includeDir, updateFolder, zip, ui, outputLogFile }) { |
There was a problem hiding this comment.
My main feedback is to break this function into smaller functions to make sense of it.
src/lib/qdl.js
Outdated
| fs.appendFileSync(outputLogFile, `${line}\n`); | ||
|
|
||
| if (line.includes('Waiting for EDL device')) { | ||
| handleError(process, `Device is not in EDL mode${os.EOL}`); |
There was a problem hiding this comment.
Suggested change
| handleError(process, `Device is not in EDL mode${os.EOL}`); | |
| handleError(process, `Ensure your device is connected and in EDL mode${os.EOL}`); |
keeramis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
flash --tachyonHow to Test
Same flashing steps using
particle.js flash --tachyonRelated Issues / Discussions
Completeness