-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEAT] Get list of batches #130
Conversation
8b3d2cb
to
8ec6287
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lastly, something to mention is as augustin is working on #131, you will probably have to rebase and change all the complete to open (and reverse the boolean value so). I would suggest to rebase your PR on his PR to avoid surprises.
5970443
to
d3566a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Couple nitpicks only
7379af0
to
363aca4
Compare
1df4db0
to
559d0d1
Compare
559d0d1
to
bcce518
Compare
83a5b7b
to
dbcd5ed
Compare
e3efcf8
to
9b0b915
Compare
9b0b915
to
a294801
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good aside from the modified sections in the changelog
8c310a2
to
cbae565
Compare
Description
This MR exposes batches list end point to the sdk with filtering.
Related PRs in other projects (PASQAL developers only)
Closely related to "Get list of jobs": #121
Additional merge criteria
None
Breaking changes
None
Checklist
Versioning (PASQAL developers only)
_version.py
following the changes in your PR and by using semantic versioning.Documentation
Tests
Internal tests pipeline (PASQAL developers only)
If your PR hasn't changed any functionality, it still needs to be validated against internal tests.
After updating the version (PASQAL developers only)