Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Get list of batches #130

Merged
merged 13 commits into from
Oct 14, 2024
Merged

[FEAT] Get list of batches #130

merged 13 commits into from
Oct 14, 2024

Conversation

quersa
Copy link
Collaborator

@quersa quersa commented Jul 30, 2024

Description

This MR exposes batches list end point to the sdk with filtering.

Related PRs in other projects (PASQAL developers only)

Closely related to "Get list of jobs": #121

Additional merge criteria

None

Breaking changes

None

Checklist

  • The title of the PR follows the right format: [{Label}] {Short Message}. Label examples: IMPROVEMENT, FIX, REFACTORING... Short message is about what your PR changes.

Versioning (PASQAL developers only)

  • Update the version of pasqal-cloud in _version.py following the changes in your PR and by using semantic versioning.

Documentation

  • Update CHANGELOG.md with a description explaining briefly the changes to the users.

Tests

  • Unit tests have been added or adjusted.
  • Tests were run locally.

Internal tests pipeline (PASQAL developers only)

  • Update and run the internal tests while targeting the branch of this PR.
    If your PR hasn't changed any functionality, it still needs to be validated against internal tests.

After updating the version (PASQAL developers only)

  • Open a PR on the internal tests that updates the version used for the pasqal-cloud backward compatibility tests.

Copy link
Collaborator

@Mildophin Mildophin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lastly, something to mention is as augustin is working on #131, you will probably have to rebase and change all the complete to open (and reverse the boolean value so). I would suggest to rebase your PR on his PR to avoid surprises.

CHANGELOG.md Outdated Show resolved Hide resolved
pasqal_cloud/_version.py Outdated Show resolved Hide resolved
pasqal_cloud/__init__.py Outdated Show resolved Hide resolved
pasqal_cloud/utils/models.py Outdated Show resolved Hide resolved
pasqal_cloud/utils/models.py Outdated Show resolved Hide resolved
pasqal_cloud/utils/models.py Outdated Show resolved Hide resolved
tests/test_batch.py Show resolved Hide resolved
tests/test_batch.py Show resolved Hide resolved
tests/test_batch.py Show resolved Hide resolved
tests/test_batch.py Outdated Show resolved Hide resolved
@quersa quersa force-pushed the es/get-list-of-batches branch 10 times, most recently from 5970443 to d3566a4 Compare August 1, 2024 19:14
Copy link
Collaborator

@MatthieuMoreau0 MatthieuMoreau0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Couple nitpicks only

pasqal_cloud/__init__.py Outdated Show resolved Hide resolved
pasqal_cloud/__init__.py Outdated Show resolved Hide resolved
pasqal_cloud/__init__.py Outdated Show resolved Hide resolved
pasqal_cloud/utils/filters.py Outdated Show resolved Hide resolved
@quersa quersa force-pushed the es/get-list-of-batches branch 4 times, most recently from 1df4db0 to 559d0d1 Compare September 6, 2024 19:04
pasqal_cloud/utils/constants.py Outdated Show resolved Hide resolved
pasqal_cloud/__init__.py Outdated Show resolved Hide resolved
pasqal_cloud/utils/constants.py Show resolved Hide resolved
@Mildophin Mildophin force-pushed the es/get-list-of-batches branch 3 times, most recently from e3efcf8 to 9b0b915 Compare October 8, 2024 12:32
Copy link
Collaborator

@Augustinio Augustinio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from the modified sections in the changelog

CHANGELOG.md Outdated Show resolved Hide resolved
@Mildophin Mildophin merged commit c0d69e0 into dev Oct 14, 2024
5 checks passed
@Mildophin Mildophin deleted the es/get-list-of-batches branch October 14, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants