-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DE-70) feat(reco): offline recommendation #3644
Open
dcuesta-pass
wants to merge
8
commits into
master
Choose a base branch
from
DE-70-update-offline-recommendation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for offline recommendations
…sponding SQL files
dcuesta-pass
commented
Dec 23, 2024
@@ -22,7 +22,9 @@ def offline_recommendation( | |||
.to_arrow() | |||
) | |||
|
|||
logger.info("Offline recommendation: Get recommendations from API...") | |||
logger.info( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/gpt
…ith dynamic API URL
… for offline recommendations
6ce9a87
to
a732419
Compare
|
174fb91
to
a57b4fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR template
Select PR template in preview mode
PR title format (except for MEP)
There is a linter on the PR title format. Please respect the following format:
(ticket) type(topic): comment
ticket surrounded by parenthesis, with optionnaly a hyphen followed by one or more digits (e.g., -1234). The first part must be one of the following strings:
type :
The second part to specify the type of change one of the following :
topic within parenthesis: 1 word e.g., (dag)
comment: tell us your life
examples: