Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(DE-685) dbt(snapshots): update model dependancies to snapshots offer and collective offer #3745

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

Jules-Arbelot
Copy link
Contributor

DA PR

Describe your changes

Please include a summary of the changes:

  • This PR [adds/removes/fixes/replaces] the [feature/bug/etc].
  • Tag a reviewer if necessacy @github/username

Type of change

  • Fix (non-breaking change which corrects expected behavior)
  • New fields (non-breaking change)
  • New table (non-breaking change)
  • Concept change (potentially breaking change which modifies fields according to new or evolving business concepts)
  • Table deletion (potentially breaking change which adds functionality/ table)

Checklist before requesting a review

  • I have performed a self-review of my code
  • Fields have been snake_cased
  • I have checked my modifications don't break downstream models
  • If my changes concern incremental table, I have altered their schema to accomodate with field's creation/deletion
  • I have updated the dag in cases of dependencies
  • My code passes CI/CD tests
  • I will post on slack review channel and ensure to specify the duration of the review task: short (<10min), medium (<30min), long (>30min)

PR title format (except for MEP)

There is a linter on the PR title format. Please respect the following format:

(ticket) type(topic): comment
  • ticket surrounded by parenthesis, with optionnaly a hyphen followed by one or more digits (e.g., -1234). The first part must be one of the following strings:

    • DA
    • DE
    • AE
    • DS
    • HF
    • BSR
    • PC
  • type :
    The second part to specify the type of change one of the following :

    • build
    • lint
    • ci
    • docs
    • feat
    • fix
    • perf
    • refactor
    • test
    • chore
    • dbt
  • topic within parenthesis: 1 word e.g., (dag)

  • comment: tell us your life

examples:

  • ✅ (DE-124) refactor(firebase): update source field
  • ❌ (DE-124) refactor (firebase): update source field (space between type and topic)
  • ❌ (DE-124) airflow(firebase): update source fiedd in DAG (wrong type)
  • ❌ (DE-124) (DE-124) refactor(firebase refacto): update source field (topic in two words)
  • ✅ (BSR) docs(github): add PR title valid format in template

@Jules-Arbelot Jules-Arbelot changed the title (de 685) dbt(snapshots) update model dependancies to snapshots offer and collective offer (DE-685) dbt(snapshots) : update model dependancies to snapshots offer and collective offer Jan 27, 2025
@Jules-Arbelot Jules-Arbelot changed the title (DE-685) dbt(snapshots) : update model dependancies to snapshots offer and collective offer (DE-685) dbt(snapshots): update model dependancies to snapshots offer and collective offer Jan 27, 2025
@vbusson-pass vbusson-pass force-pushed the master branch 2 times, most recently from 174fb91 to a57b4fc Compare January 29, 2025 08:09
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
22.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants