Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update detox-tests.yml #63

Merged
merged 8 commits into from
Jan 15, 2025
Merged

Update detox-tests.yml #63

merged 8 commits into from
Jan 15, 2025

Conversation

rickycpadilla
Copy link
Collaborator

@rickycpadilla rickycpadilla commented Jan 15, 2025

What's New?

In the test app:

  • update react native version to fix "boost" cocoapod issue
  • add react-native-gradle-plugin, which is required for new react native version
  • make improvements to detox test workflow

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have manually tested my code thoroughly
  • I have added/updated inline documentation for public facing interfaces if relevant
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing integration and unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@rickycpadilla rickycpadilla requested a review from a team January 15, 2025 17:40
@rickycpadilla rickycpadilla merged commit 71f6167 into main Jan 15, 2025
4 checks passed
@rickycpadilla rickycpadilla deleted the update-ios-detox branch January 15, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants