Minimize dependencies of VPN implementations #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decouple WireGuardAdapterDelegate from connection.
Keep CPassepartoutCryptoOpenSSL free of PassepartoutKit: - Move Allocation/ZeroingData to the CryptoOpenSSL package (internal use) - Rename ZeroingData.count to .length for consistency with NSData - Duplicate some Data manipulation code in CryptoOpenSSL - Add a simplified version of ZeroingData in PassepartoutKit called AutoerasingData to retain SecureData operation
keeshux
changed the title
keeshux
added a commit
that referenced
this pull request
Jan 15, 2025
The delegate was lost due to not being retained anywhere, and the WireGuard adapter was therefore not finalizing the connection (i.e. set tunnel settings). Regression in #1057
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenVPN
WireGuard
internal