Simplify Rails Integration #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows easy inclusion within a Rails application by auto-loading the engine if Rails is defined. This is a given as apps require rails before doing Bundler.setup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves an issue which currently happens, attempting to load rbexy into a fresh rails application. You get odd constant undefined errors due to trying to find constants in the wrong module.
This was simplified by including all of
action_view. We depend on quite a few things from ActionView. Including the main module merely defines autoloads for the library, but does not include anything until requested. This seems to ensure things get loaded in whatever order they need to get loaded in. (apparently therequire's within the rails code is... for show?)This also simplifies Rails integration by auto-loading the engine if we're in the Rails environment. Rails apps explicitly require rails before loading bundled gems (in
application.rb), there for we're guaranteed it is defined.