Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve aggregate id argument resolver #575

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

DavidBadura
Copy link
Member

@DavidBadura DavidBadura commented Apr 12, 2024

Aggregate ID resolver has been changed. Instead of a string you now get an AggregateID instance.
I also adapted the docs.

@DavidBadura DavidBadura added this to the 3.0.0 milestone Apr 12, 2024
@DavidBadura DavidBadura added the enhancement New feature or request label Apr 12, 2024
Copy link

Hello 👋

here is the most recent benchmark result:

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 918.100μs (±0.00%) | 874.500μs (±0.00%) | +4.99%    | 34.264mb        | 34.272mb   | -0.02%      |
| benchLoad10000Events ()                | 54.258ms (±0.00%)  | 51.618ms (±0.00%)  | +5.12%    | 34.264mb        | 33.762mb   | +1.49%      |
| benchSave1Event ()                     | 1.207ms (±0.00%)   | 980.900μs (±0.00%) | +23.04%   | 33.762mb        | 33.762mb   | 0.00%       |
| benchSave10000Events ()                | 229.075ms (±0.00%) | 234.420ms (±0.00%) | -2.28%    | 33.762mb        | 33.762mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.658s (±0.00%)    | 8.752s (±0.00%)    | -1.08%    | 33.763mb        | 33.763mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 6.892s (±0.00%)    | 6.875s (±0.00%)    | +0.24%    | 33.763mb        | 33.763mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 51.734ms (±0.00%)  | 52.644ms (±0.00%)  | -1.73%    | 33.763mb        | 33.763mb   | 0.00%       |
| benchLoad10000Events ()                | 810.000μs (±0.00%) | 815.400μs (±0.00%) | -0.66%    | 33.763mb        | 33.763mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 5.034ms (±0.00%)   | 4.926ms (±0.00%)   | +2.18%    | 37.069mb        | 37.069mb   | 0.00%       |
| benchSave10000Events () | 377.494ms (±0.00%) | 386.891ms (±0.00%) | -2.43%    | 37.070mb        | 37.070mb   | 0.00%       |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.063s (±0.00%) | 3.030s (±0.00%) | +1.07%    | 34.162mb        | 34.162mb   | 0.00%       |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 846.600μs (±0.00%) | 838.300μs (±0.00%) | +0.99%    | 35.707mb        | 35.707mb   | 0.00%       |
| benchLoad10000Events ()                | 92.369ms (±0.00%)  | 87.237ms (±0.00%)  | +5.88%    | 35.707mb        | 35.707mb   | 0.00%       |
| benchSave1Event ()                     | 1.700ms (±0.00%)   | 1.717ms (±0.00%)   | -0.96%    | 35.707mb        | 35.707mb   | 0.00%       |
| benchSave10000Events ()                | 253.471ms (±0.00%) | 253.322ms (±0.00%) | +0.06%    | 35.709mb        | 35.709mb   | 0.00%       |
| benchSave10000Aggregates ()            | 13.096s (±0.00%)   | 12.814s (±0.00%)   | +2.20%    | 35.707mb        | 35.707mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 10.960s (±0.00%)   | 10.949s (±0.00%)   | +0.10%    | 36.278mb        | 36.278mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura merged commit a90bbdc into 3.0.x Apr 12, 2024
35 of 36 checks passed
@DanielBadura DanielBadura deleted the improve-aggregate-id-argument-resolver branch April 16, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants