Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dont teardown new subscriptions #641

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Conversation

DavidBadura
Copy link
Member

Do not try to teardown new subscriptions because they have not been set up. This way there is nothing to teardown and the subscription can simply be deleted from the DB. Otherwise you always get an error message.

@DavidBadura DavidBadura added the bug Something isn't working label Oct 16, 2024
@DavidBadura DavidBadura added this to the 3.4.1 milestone Oct 16, 2024
Copy link

github-actions bot commented Oct 16, 2024

Hello 👋

here is the most recent benchmark result:

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.126s (±0.00%) | 3.282s (±0.00%) | -4.77%    | 34.736mb        | 34.744mb   | -0.02%      |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBatchBench
============================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 87.779ms (±0.00%) | 93.470ms (±0.00%) | -6.09%    | 34.234mb        | 34.234mb   | 0.00%       |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 890.300μs (±0.00%) | 899.500μs (±0.00%) | -1.02%    | 34.744mb        | 34.744mb   | 0.00%       |
| benchLoad10000Events ()                | 48.183ms (±0.00%)  | 47.717ms (±0.00%)  | +0.98%    | 34.744mb        | 34.744mb   | 0.00%       |
| benchSave1Event ()                     | 3.695ms (±0.00%)   | 4.643ms (±0.00%)   | -20.41%   | 34.744mb        | 34.744mb   | 0.00%       |
| benchSave10000Events ()                | 229.531ms (±0.00%) | 260.281ms (±0.00%) | -11.81%   | 34.744mb        | 34.744mb   | 0.00%       |
| benchSave10000Aggregates ()            | 33.746s (±0.00%)   | 44.124s (±0.00%)   | -23.52%   | 34.744mb        | 34.744mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 4.784s (±0.00%)    | 4.828s (±0.00%)    | -0.89%    | 34.744mb        | 34.744mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 48.130ms (±0.00%)  | 48.484ms (±0.00%)  | -0.73%    | 33.836mb        | 33.836mb   | 0.00%       |
| benchLoad10000Events ()                | 930.700μs (±0.00%) | 935.900μs (±0.00%) | -0.56%    | 33.836mb        | 33.836mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 4.339ms (±0.00%)   | 4.328ms (±0.00%)   | +0.26%    | 37.072mb        | 37.072mb   | 0.00%       |
| benchSave10000Events () | 365.969ms (±0.00%) | 482.964ms (±0.00%) | -24.22%   | 37.144mb        | 37.144mb   | 0.00%       |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 892.400μs (±0.00%) | 868.200μs (±0.00%) | +2.79%    | 34.895mb        | 34.895mb   | 0.00%       |
| benchLoad10000Events ()                | 84.390ms (±0.00%)  | 83.984ms (±0.00%)  | +0.48%    | 34.895mb        | 34.895mb   | 0.00%       |
| benchSave1Event ()                     | 3.832ms (±0.00%)   | 4.695ms (±0.00%)   | -18.40%   | 34.895mb        | 34.895mb   | 0.00%       |
| benchSave10000Events ()                | 261.643ms (±0.00%) | 273.824ms (±0.00%) | -4.45%    | 34.897mb        | 34.897mb   | 0.00%       |
| benchSave10000Aggregates ()            | 38.703s (±0.00%)   | 51.022s (±0.00%)   | -24.14%   | 34.895mb        | 34.895mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 8.845s (±0.00%)    | 8.884s (±0.00%)    | -0.44%    | 35.396mb        | 35.396mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 964.500μs (±0.00%) | 976.100μs (±0.00%) | -1.19%    | 33.765mb        | 33.765mb   | 0.00%       |
| benchLoad10000Events ()                | 48.561ms (±0.00%)  | 49.463ms (±0.00%)  | -1.82%    | 33.765mb        | 33.765mb   | 0.00%       |
| benchSave1Event ()                     | 3.401ms (±0.00%)   | 4.207ms (±0.00%)   | -19.16%   | 33.765mb        | 33.765mb   | 0.00%       |
| benchSave10000Events ()                | 247.940ms (±0.00%) | 272.125ms (±0.00%) | -8.89%    | 33.765mb        | 33.765mb   | 0.00%       |
| benchSave10000Aggregates ()            | 38.036s (±0.00%)   | 51.834s (±0.00%)   | -26.62%   | 33.765mb        | 33.765mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 4.781s (±0.00%)    | 4.774s (±0.00%)    | +0.14%    | 33.765mb        | 33.765mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

@DavidBadura DavidBadura reopened this Oct 16, 2024
@DavidBadura DavidBadura changed the base branch from 3.4.x to 3.5.x October 16, 2024 18:18
@DavidBadura DavidBadura modified the milestones: 3.4.1, 3.5.0 Oct 16, 2024
Copy link
Member

@DanielBadura DanielBadura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI fail is unrelated - should still wait until it is green.

@DavidBadura DavidBadura merged commit eb6fde7 into 3.5.x Oct 17, 2024
39 of 40 checks passed
@DavidBadura DavidBadura deleted the fix-subscription-remove branch October 17, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants