Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ChainTranslator: Dont override the result keys, merge instead #665

Merged
merged 2 commits into from
Dec 30, 2024

Conversation

DanielBadura
Copy link
Member

No description provided.

@DanielBadura DanielBadura added the bug Something isn't working label Dec 30, 2024
@DanielBadura DanielBadura added this to the 3.6.3 milestone Dec 30, 2024
@DanielBadura DanielBadura self-assigned this Dec 30, 2024
@DavidBadura DavidBadura merged commit 7724096 into 3.6.x Dec 30, 2024
@DavidBadura DavidBadura deleted the fix-chain-translator branch December 30, 2024 15:27
Copy link

github-actions bot commented Dec 30, 2024

Hello 👋

here is the most recent benchmark result:

SimpleSetupBench
================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 956.600μs (±0.00%) | 1.011ms (±0.00%)   | -5.37%    | 34.266mb        | 34.274mb   | -0.02%      |
| benchLoad10000Events ()                | 51.132ms (±0.00%)  | 49.565ms (±0.00%)  | +3.16%    | 34.266mb        | 33.765mb   | +1.48%      |
| benchSave1Event ()                     | 947.900μs (±0.00%) | 987.900μs (±0.00%) | -4.05%    | 34.266mb        | 33.765mb   | +1.48%      |
| benchSave10000Events ()                | 216.914ms (±0.00%) | 223.441ms (±0.00%) | -2.92%    | 33.765mb        | 33.765mb   | 0.00%       |
| benchSave10000Aggregates ()            | 7.973s (±0.00%)    | 8.098s (±0.00%)    | -1.54%    | 33.765mb        | 33.765mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 4.885s (±0.00%)    | 4.857s (±0.00%)    | +0.56%    | 33.765mb        | 33.765mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SnapshotsBench
==============

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000EventsMissingSnapshot () | 49.922ms (±0.00%)  | 50.208ms (±0.00%)  | -0.57%    | 33.836mb        | 33.836mb   | 0.00%       |
| benchLoad10000Events ()                | 913.500μs (±0.00%) | 920.000μs (±0.00%) | -0.71%    | 33.836mb        | 33.836mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBatchBench
============================

+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                                   | memory                                     |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>    | Tag: base         | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 73.779ms (±0.00%) | 73.939ms (±0.00%) | -0.22%    | 34.234mb        | 34.234mb   | 0.00%       |
+---------------------------+-------------------+-------------------+-----------+-----------------+------------+-------------+

SubscriptionEngineBench
=======================

+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
|                           | time (kde mode)                               | memory                                     |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| subject                   | Tag: <current>  | Tag: base       | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+
| benchHandle10000Events () | 3.166s (±0.00%) | 3.183s (±0.00%) | -0.54%    | 46.382mb        | 46.382mb   | 0.00%       |
+---------------------------+-----------------+-----------------+-----------+-----------------+------------+-------------+

PersonalDataBench
=================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 927.400μs (±0.00%) | 920.700μs (±0.00%) | +0.73%    | 34.895mb        | 34.895mb   | 0.00%       |
| benchLoad10000Events ()                | 86.906ms (±0.00%)  | 85.361ms (±0.00%)  | +1.81%    | 34.895mb        | 34.895mb   | 0.00%       |
| benchSave1Event ()                     | 1.585ms (±0.00%)   | 1.519ms (±0.00%)   | +4.28%    | 34.895mb        | 34.895mb   | 0.00%       |
| benchSave10000Events ()                | 249.273ms (±0.00%) | 249.376ms (±0.00%) | -0.04%    | 34.897mb        | 34.897mb   | 0.00%       |
| benchSave10000Aggregates ()            | 12.280s (±0.00%)   | 12.252s (±0.00%)   | +0.23%    | 34.895mb        | 34.895mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 9.025s (±0.00%)    | 8.982s (±0.00%)    | +0.47%    | 35.396mb        | 35.396mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SimpleSetupStreamStoreBench
===========================

+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                                        | time (kde mode)                                     | memory                                     |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                                | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad1Event ()                     | 1.041ms (±0.00%)   | 1.048ms (±0.00%)   | -0.64%    | 34.862mb        | 34.862mb   | 0.00%       |
| benchLoad10000Events ()                | 56.948ms (±0.00%)  | 57.002ms (±0.00%)  | -0.09%    | 34.862mb        | 34.862mb   | 0.00%       |
| benchSave1Event ()                     | 1.123ms (±0.00%)   | 1.080ms (±0.00%)   | +4.01%    | 34.862mb        | 34.862mb   | 0.00%       |
| benchSave10000Events ()                | 294.819ms (±0.00%) | 298.411ms (±0.00%) | -1.20%    | 34.862mb        | 34.862mb   | 0.00%       |
| benchSave10000Aggregates ()            | 8.361s (±0.00%)    | 8.347s (±0.00%)    | +0.16%    | 34.862mb        | 34.862mb   | 0.00%       |
| benchSave10000AggregatesTransaction () | 5.071s (±0.00%)    | 5.068s (±0.00%)    | +0.07%    | 34.862mb        | 34.862mb   | 0.00%       |
+----------------------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

SplitStreamBench
================

+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
|                         | time (kde mode)                                     | memory                                     |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| subject                 | Tag: <current>     | Tag: base          | time-diff | Tag: <current>  | Tag: base  | memory-diff |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+
| benchLoad10000Events () | 4.318ms (±0.00%)   | 4.316ms (±0.00%)   | +0.04%    | 37.072mb        | 37.072mb   | 0.00%       |
| benchSave10000Events () | 336.915ms (±0.00%) | 341.270ms (±0.00%) | -1.28%    | 37.144mb        | 37.144mb   | 0.00%       |
+-------------------------+--------------------+--------------------+-----------+-----------------+------------+-------------+

This comment gets update everytime a new commit comes in!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants