-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add union object normalizer #40
base: 1.3.x
Are you sure you want to change the base?
Conversation
Hello 👋 here is the most recent benchmark result:
This comment gets update everytime a new commit comes in! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feature itself LGTM.
Just thinking about instead of passing an array to the UnionObjectNormalizer
leveraging the #[NormalizedName]
Attribute or something like that. But also that is kina weird, since it does not really bring any value itself.
/** @param array<class-string, string> $classToTypeMap */ | ||
public function __construct( | ||
private readonly array|null $classToTypeMap = null, | ||
private readonly string $typeFieldName = '_type', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not the type but instead the type key right?
No description provided.