-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scalarlike now just goes by its name in equinox ecosystem documentation #292
base: main
Are you sure you want to change the base?
Scalarlike now just goes by its name in equinox ecosystem documentation #292
Conversation
Actually, this raises a question I should have spotted earlier -- FWIW the convention I've been using elsewhere is to strip jaxtyping shape/dtypes in documentation (mostly as I haven't wanted to assume familiarity with jaxtyping syntax for those reading the docs): In which case perhaps we want this to be rendered as |
In optimistix, we use it to type values that should be |
I agree, it should be clear! Which is why I'm thinking of stripping that information here for (a) readability for those unfamiliar with jaxtyping and (b) consistency. As an alternative, we could consider turning on jaxtyping annotations in documentation for the whole ecosystem? The library has quite possibly achieved critical mass at this point, that a large enough fraction of readers will know what it means? |
I would prefer that, I find jaxtyping's expressiveness very useful! To get back to the previous example - for a learning rate it might not be too confusing to use |
In that case at minimum let's replace this here to just return |
"here" being where? More specifically, I find the |
As suggested in patrick-kidger/optimistix#109.
I built the optimistix documentation with jaxtyping from this branch, and it works splendidly.