Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin test-unit gem to ensure CI works on Ruby 1.9 #67

Merged
merged 1 commit into from
Dec 25, 2024
Merged

Conversation

mattbrictson
Copy link
Collaborator

@mattbrictson mattbrictson commented Dec 25, 2024

The test-unit gem recently added Ruby 2 keyword arguments to its implementation. This breaks our CI tests when running on Ruby 1.9, with errors like this:

/home/runner/work/plist/plist/vendor/bundle/ruby/1.9.1/gems/test-unit-3.6.7/lib/test/unit.rb:3:in `require':
/home/runner/work/plist/plist/vendor/bundle/ruby/1.9.1/gems/test-unit-3.6.7/lib/test/unit/testcase.rb:580:
syntax error, unexpected tLABEL (SyntaxError)
      def run(result, runner_class: nil)
                                   ^

Fix by pinning to an older version of the test-unit gem when running on Ruby 1.9.

@mattbrictson mattbrictson marked this pull request as ready for review December 25, 2024 23:14
@mattbrictson mattbrictson merged commit 6eab99f into master Dec 25, 2024
15 checks passed
@mattbrictson mattbrictson deleted the fix-ci-1.9 branch December 25, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant