Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug - v5 Charts - update CodeSandbox examples #11458

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Bug - v5 Charts - update CodeSandbox examples #11458

merged 1 commit into from
Jan 24, 2025

Conversation

dlabrecq
Copy link
Member

@dlabrecq dlabrecq commented Jan 22, 2025 •
edited
Loading

Some chart examples are missing ChartThemeColor import statements. As a result, CodeSandbox examples fail to load.

Also updated Victory to the latest packages.

#11456

@dlabrecq dlabrecq marked this pull request as draft January 22, 2025 16:10
@dlabrecq dlabrecq changed the base branch from main to v5 January 22, 2025 16:13
@dlabrecq dlabrecq force-pushed the v5-sandbox-fixes branch 2 times, most recently from f06e14c to 05711d2 Compare January 22, 2025 16:15
@dlabrecq dlabrecq changed the title Bug - Charts - update v5 CodeSandbox examples Bug - v5 Charts - update Victory and CodeSandbox examples Jan 22, 2025
@patternfly-build
Copy link
Contributor

patternfly-build commented Jan 22, 2025 •
edited
Loading

Preview: https://patternfly-react-pr-11458.surge.sh

A11y report: https://patternfly-react-pr-11458-a11y.surge.sh

@dlabrecq dlabrecq marked this pull request as ready for review January 22, 2025 16:22
@dlabrecq dlabrecq changed the title Bug - v5 Charts - update Victory and CodeSandbox examples Bug - v5 Charts - update CodeSandbox examples Jan 22, 2025
@mfrances17 mfrances17 merged commit 57508ec into patternfly:v5 Jan 24, 2025
13 checks passed
@patternfly-build
Copy link
Contributor

Your changes have been released in:

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thatblindgeye thatblindgeye thatblindgeye approved these changes

@mfrances17 mfrances17 mfrances17 approved these changes

@gitdallas gitdallas gitdallas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dlabrecq @patternfly-build @gitdallas @mfrances17 @thatblindgeye