Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bug): Updated code to use actionable card. #65

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

dlabaj
Copy link
Contributor

@dlabaj dlabaj commented Jul 25, 2024

Updated code to use actionable card instead of custom link code.

@dlabaj dlabaj added the bug Something isn't working label Jul 25, 2024
@dlabaj dlabaj self-assigned this Jul 25, 2024
@dlabaj dlabaj linked an issue Jul 25, 2024 that may be closed by this pull request
@patternfly-build
Copy link

patternfly-build commented Jul 25, 2024

Copy link
Collaborator

@wise-king-sullyman wise-king-sullyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A11y characteristics seem to be a bit degraded by this change, i.e. when using VO it's no longer announced that the card is a link.

Definitely looks nicer though.

Copy link

@kmcfaul kmcfaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good besides what @wise-king-sullyman already stated. The build should just need a rerun to pass the upload.

@dlabaj dlabaj merged commit e872aa1 into patternfly:v6 Jul 26, 2024
4 of 5 checks passed
Copy link

🎉 This PR is included in version 6.0.0-alpha.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released on @alpha
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - Catalog tile linked variant hover states
4 participants