Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(hackfont) overhaul install for Win11 to use chocolatey-font-helpers.extension #238

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

teknowledgist
Copy link

Requirements

Description

This just upgrades this package to use the chocolatey-font-helpers.extension which installs and uninstalls the fonts "properly" without issue in both Win10 and Win11.

Motivation and Context

The current package installs the fonts in Win10 (with a couple popup windows), but does not successfully remove the fonts on uninstall. In Windows 11, this package causes a "This is not a valid font file." error message and does not actually install the fonts (although Chocolatey believes it was successful).

How Has this Been Tested?

Tested install/uninstall in both Win10 and Win11.

I have not tested this package in the chocolatey test environment (because it is difficulty for me), but multiple other font packages that use the chocolatey-font-helpers.extension have been tested in the environment and there is nothing different about this one other than the font files (which are the same for this package as before).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this repository (if your change does not follow the style it will likely be rejected - this includes changes in formatting / layout).
  • My change requires a change to the documentation (this usually means the notes in the description of a package) and I have updated the documentation accordingly.
  • I have updated the package description and it is less than 4000 characters.
  • The added / modified package passed install / uninstall in the chocolatey test environment.
  • The changes only affect a single package (not including meta package).

Win11 installs/accepts fonts differently, and this package causes a "This is not a valid font file." error message. The chocolatey-font-helpers.extension installs the fonts without issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant