Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove checking remote description has different ICE credentials #1172

Merged
merged 3 commits into from
May 25, 2024

Conversation

xicilion
Copy link
Contributor

In the WebRTC Direct protocol, we need to allow local and remote to use the same ufrag and pwd.

@xicilion xicilion changed the title Disable comparing local and remote iceUfrag and icePwd in validateRem… Disable comparing local and remote iceUfrag and icePwd. May 10, 2024
@xicilion xicilion changed the title Disable comparing local and remote iceUfrag and icePwd. Disable comparing iceUfrag/icePwd between local and remote. May 10, 2024
@paullouisageneau
Copy link
Owner

I get the idea, but this disables a useful check (it's common for users to mess up signaling and send back the description into the same peer connection). I wonder if there is a way to check for such a scenario that doesn't rely on ICE attributes.

@xicilion
Copy link
Contributor Author

mSessionId is randomly generated each time, the probability of duplication is very small, is it possible to check if mSessionId is equal?

@xicilion xicilion changed the title Disable comparing iceUfrag/icePwd between local and remote. check localDescription and remoteDescription using mSessionId. May 12, 2024
@xicilion
Copy link
Contributor Author

@paullouisageneau how about check mSessionId?

@paullouisageneau
Copy link
Owner

It makes sense, the problem is that while session id is currently randomly generated in libdatachannel, it is not guaranteed to be unique between endpoints (other implementations typically use a timestamp), so it feels a bit clumsy. Since I've no better idea, I think you can remove the check.

@xicilion
Copy link
Contributor Author

sure, I'll do it.

@paullouisageneau paullouisageneau changed the title check localDescription and remoteDescription using mSessionId. Remove check that remote description has different ICE credentials May 25, 2024
@paullouisageneau paullouisageneau changed the title Remove check that remote description has different ICE credentials Remove checking remote description has different ICE credentials May 25, 2024
@paullouisageneau paullouisageneau merged commit d9befcf into paullouisageneau:master May 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants