-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove checking remote description has different ICE credentials #1172
Remove checking remote description has different ICE credentials #1172
Conversation
I get the idea, but this disables a useful check (it's common for users to mess up signaling and send back the description into the same peer connection). I wonder if there is a way to check for such a scenario that doesn't rely on ICE attributes. |
mSessionId is randomly generated each time, the probability of duplication is very small, is it possible to check if mSessionId is equal? |
@paullouisageneau how about check mSessionId? |
It makes sense, the problem is that while session id is currently randomly generated in libdatachannel, it is not guaranteed to be unique between endpoints (other implementations typically use a timestamp), so it feels a bit clumsy. Since I've no better idea, I think you can remove the check. |
sure, I'll do it. |
…eRemoteDescription.
In the WebRTC Direct protocol, we need to allow local and remote to use the same ufrag and pwd.