-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replaced 'winston-logfmt' by 'winston' package. #3
Replaced 'winston-logfmt' by 'winston' package. #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's an important requirement to maintain structured logging.
I don't have the bandwidth to fix the logfmt implementation atm, but maybe you could enable the Winston builtin json logger ?
@paulrostorp With the
Isn't that structured enough? |
@jeroenvermeulen That isn't a structure log management tools support by default and can index+search easily. Most log management tools have built-in support logfmt and json logs, including Grafana Loki which I use. Winston's JSON logger will suffice: https://github.com/winstonjs/winston#usage |
@paulrostorp Updated PR. Now it logs like this:
|
Fixes #2