Merge pull request #32 from paulsengroup/feature/log-ratio

Change how the log ratio is computed

src/libnchg/nchg_impl.hpp

@@ -387,7 +387,7 @@ inline auto NCHG<File>::compute(const hictk::GenomicInterval &range1,
   const auto odds_ratio = compute_odds_ratio(obs, static_cast<double>(obs_sum), N1, N2);
   const auto omega = intra_matrix ? compute_odds_ratio(exp, exp_sum, L1, L2) : 1;
 
-  const auto log_ratio = std::log2(odds_ratio) - std::log2(omega);
+  const auto log_ratio = std::log2(obs) - std::log2(exp);
 
   if ((L1 - exp) * (L2 - exp) <= cutoff) {
     return {p, exp, 1.0, log_ratio, odds_ratio, omega};