Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major refactor #39

Merged
merged 64 commits into from
Nov 11, 2024
Merged

Major refactor #39

merged 64 commits into from
Nov 11, 2024

Conversation

robomics
Copy link
Contributor

@robomics robomics commented Oct 28, 2024

  • Refactor code to take advantage of new C++20 and C++23 features
  • Reduce use of templates
  • Improve handling of missing files
  • Improve detection of existing files that would be overwritten
  • Improve logging
  • Fix bug uncovered by the refactor 3f5cd3e, 9dc028d

@robomics robomics added the enhancement New feature or request label Oct 28, 2024
Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 72.50516% with 799 lines in your changes missing coverage. Please review.

Project coverage is 74.25%. Comparing base (1291bf8) to head (a2df436).
Report is 65 commits behind head on main.

Files with missing lines Patch % Lines
src/nchg/compute/compute.cpp 64.32% 96 Missing and 31 partials ⚠️
src/nchg/common/io.cpp 72.80% 73 Missing and 20 partials ⚠️
src/libnchg/expected_values.cpp 83.80% 46 Missing and 35 partials ⚠️
src/nchg/main.cpp 47.01% 74 Missing and 6 partials ⚠️
src/libnchg/expected_values_aggregator.cpp 62.76% 62 Missing and 8 partials ⚠️
src/libnchg/nchg.cpp 85.82% 37 Missing and 17 partials ⚠️
src/nchg/expected/expected.cpp 20.89% 50 Missing and 3 partials ⚠️
src/nchg/filter/filter.cpp 65.80% 46 Missing and 7 partials ⚠️
src/nchg/merge/merge.cpp 63.46% 31 Missing and 7 partials ⚠️
src/nchg/common/io_impl.hpp 76.35% 19 Missing and 16 partials ⚠️
... and 17 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
- Coverage   74.56%   74.25%   -0.32%     
==========================================
  Files          21       32      +11     
  Lines        3834     4296     +462     
  Branches      403      445      +42     
==========================================
+ Hits         2859     3190     +331     
- Misses        748      853     +105     
- Partials      227      253      +26     
Flag Coverage Δ
[tests integration](https://app.codecov.io/gh/paulsengroup/NCHG/pull/39/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 71.67% <69.22%> (+2.16%)
[tests unittests](https://app.codecov.io/gh/paulsengroup/NCHG/pull/39/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 68.28% <67.41%> (-11.91%)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robomics robomics force-pushed the refactor/cxx23 branch 2 times, most recently from 7e32e43 to 47ba581 Compare November 6, 2024 19:40
Assertion does not hold for expected matrices.
@robomics robomics force-pushed the refactor/cxx23 branch 2 times, most recently from 482b09c to 666135a Compare November 7, 2024 18:00
@robomics robomics merged commit 0ca970b into main Nov 11, 2024
70 of 72 checks passed
@robomics robomics deleted the refactor/cxx23 branch November 11, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant