-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major refactor #39
Merged
Merged
Major refactor #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
robomics
commented
Oct 28, 2024
•
edited
Loading
edited
- Refactor code to take advantage of new C++20 and C++23 features
- Reduce use of templates
- Improve handling of missing files
- Improve detection of existing files that would be overwritten
- Improve logging
- Fix bug uncovered by the refactor 3f5cd3e, 9dc028d
Counts for individual pixels are extremely unlikely to overflow uint32s, however when aggregating interactions over a list of user-provided domains, if the domains are large enough and the underlying matrix is fairly dense, an overflow may be possible.
robomics
force-pushed
the
refactor/cxx23
branch
2 times, most recently
from
November 6, 2024 19:40
7e32e43
to
47ba581
Compare
robomics
force-pushed
the
refactor/cxx23
branch
from
November 6, 2024 19:58
47ba581
to
49c109c
Compare
Assertion does not hold for expected matrices.
robomics
force-pushed
the
refactor/cxx23
branch
2 times, most recently
from
November 7, 2024 18:00
482b09c
to
666135a
Compare
robomics
force-pushed
the
refactor/cxx23
branch
from
November 7, 2024 18:10
666135a
to
5b71748
Compare
…ing the matrix diagonal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.