Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of NCHG cartesian-product #43

Merged
merged 18 commits into from
Nov 13, 2024

Fix CI

098f3e3
Select commit
Loading
Failed to load commit list.
Merged

Initial implementation of NCHG cartesian-product #43

Fix CI
098f3e3
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 13, 2024 in 1s

74.08% (-0.24%) compared to 0ca970b

View this Pull Request on Codecov

74.08% (-0.24%) compared to 0ca970b

Details

Codecov Report

Attention: Patch coverage is 69.67213% with 222 lines in your changes missing coverage. Please review.

Project coverage is 74.08%. Comparing base (0ca970b) to head (098f3e3).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/nchg/compute/compute.cpp 63.38% 94 Missing and 25 partials ⚠️
src/nchg/cartesian_product/cartesian_product.cpp 70.03% 68 Missing and 21 partials ⚠️
src/nchg/cli.cpp 88.63% 6 Missing and 4 partials ⚠️
src/nchg/common/io_impl.hpp 69.23% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #43      +/-   ##
==========================================
- Coverage   74.32%   74.08%   -0.24%     
==========================================
  Files          32       34       +2     
  Lines        4296     4924     +628     
  Branches      445      531      +86     
==========================================
+ Hits         3193     3648     +455     
- Misses        850      985     +135     
- Partials      253      291      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.