Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure codebase #46

Merged
merged 9 commits into from
Nov 13, 2024
Merged

Restructure codebase #46

merged 9 commits into from
Nov 13, 2024

Conversation

robomics
Copy link
Contributor

@robomics robomics commented Nov 13, 2024 •
edited
Loading

@robomics robomics added enhancement New feature or request dependencies Pull requests that update a dependency file labels Nov 13, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 71.94719% with 170 lines in your changes missing coverage. Please review.

Project coverage is 73.81%. Comparing base (733e948) to head (51155e1).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
src/io/parquet_stats_file_writer.cpp 59.09% 56 Missing and 16 partials ⚠️
src/io/parquet_stats_file_reader.cpp 66.89% 42 Missing and 7 partials ⚠️
src/io/parquet_stats_file_writer_impl.hpp 73.61% 13 Missing and 6 partials ⚠️
src/io/text.cpp 73.33% 9 Missing and 3 partials ⚠️
src/io/parquet_stats_file_helpers.cpp 87.71% 5 Missing and 2 partials ⚠️
src/io/parquet_stats_file_reader_impl.hpp 91.04% 1 Missing and 5 partials ⚠️
src/io/text_impl.hpp 69.23% 3 Missing and 1 partial ⚠️
src/nchg/compute/compute.cpp 88.88% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #46      +/-   ##
==========================================
- Coverage   74.06%   73.81%   -0.26%     
==========================================
  Files          34       39       +5     
  Lines        4924     4983      +59     
  Branches      531      533       +2     
==========================================
+ Hits         3647     3678      +31     
- Misses        985     1016      +31     
+ Partials      292      289       -3
Flag Coverage Δ
[tests integration](https://app.codecov.io/gh/paulsengroup/NCHG/pull/46/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 71.56% <71.94%> (-0.26%)
[tests unittests](https://app.codecov.io/gh/paulsengroup/NCHG/pull/46/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=paulsengroup) 68.41% <ø> (+0.12%)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robomics
Update stocc's CMakeLists.txt
66dd676 
- Always build as static library
- Build using -std=c++23
@robomics
Drop Windows CI
e4d5536 
For the time being, MSVC does not support C++23 well enough to build NCHG,
and windows-ci.yml is outdated to the point where it is not worth keeping it
around. When C++23 support on MSVC is in a better state we can consider re-adding
the CI workflow for Windows.
@robomics robomics merged commit e85d095 into main Nov 13, 2024
72 of 74 checks passed
@robomics robomics deleted the refactor branch November 13, 2024 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@robomics