Support linking to Arrow::python instead of Arrow::arrow_shared #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is mostly useful for hickpy, where linking to Arrow::arrow_shared causes linking to a specific version of Arrow (which depends on the specific version of Pyarrow that was installed when building hictkpy wheels). This is not desirable, because it forces us to pin the version of pyarrow required by hictkpy (which could easily result in unresolvable environments). Here we assume that libarrow_python.so links to some version of libarrow.so, which when loaded brings in all symbols required by hictk and hictkpy. It should be noted that Arrow has very few guarantees when it comes to ABI stability (see apache/arrow#41707). This means that hictkpy needs to test all possible combinations of pyarrow/arrow versions on all supported platforms and architectures to make sure there are no ABI changes (at least to the parts that hictk and hictkpy depend on).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #295 +/- ##
==========================================
- Coverage 79.17% 77.54% -1.64%
==========================================
Files 173 173
Lines 17035 21207 +4172
Branches 2309 2309
==========================================
+ Hits 13488 16445 +2957
- Misses 2540 3755 +1215
Partials 1007 1007
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
robomics
added a commit
to paulsengroup/hictkpy
that referenced
this pull request
Oct 17, 2024
See paulsengroup/hictk#295 for the rationale.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mostly useful for hickpy, where linking to Arrow::arrow_shared causes linking to a specific version of Arrow (which depends on the specific version of Pyarrow that was installed when building hictkpy wheels).
This is not desirable, because it forces us to pin the version of pyarrow required by hictkpy (which could easily result in unresolvable environments).
Here we assume that libarrow_python.so links to some version of libarrow.so, which when loaded brings in all symbols required by hictk and hictkpy.
It should be noted that Arrow has very few guarantees when it comes to ABI stability (see apache/arrow#41707).
This means that hictkpy needs to test all possible combinations of pyarrow/arrow versions on all supported platforms and architectures to make sure there are no ABI changes (at least to the parts that hictk and hictkpy depend on).