Frontend: Allow console debug statement in development (Cloud-CV#983)

* Frontend: Allow console debug statement in development * Change eslint no-console error to warnings * Dev server will stop only for lint errors not for warnings * Solved authCtrl console bug
payamka · Jun 1, 2017 · df78b62 · df78b62
1 parent 18c47d0
commit df78b62
Show file tree

Hide file tree

Showing 3 changed files with 22 additions and 18 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -18,12 +18,8 @@ eslint config file.
 	"extends": "eslint:recommended",
 
 	"rules": {
-		"no-console": [
-			"error", { 
-				allow: ["warn", "error"] 
-			}
-		],
-		"semi": [2, 
+		"no-console": "warn",
+		"semi": ["error", 
 			"always", { 
 				"omitLastInOneLineBlock": true 
 			}

diff --git a/frontend/src/js/controllers/authCtrl.js b/frontend/src/js/controllers/authCtrl.js
@@ -113,8 +113,8 @@
 
                                 }
 
-                            } catch (error) { /*eslint no-console: ["error", {allow: ["warn", "error"]}]*/
-                                console.error(error);
+                            } catch (error) { 
+                                console.log(error);
                             }
                         }
                         vm.stopLoader();
@@ -158,8 +158,8 @@
                                 if (non_field_errors) {
                                     vm.FormError = response.data.non_field_errors[0];
                                 }
-                            } catch (error) { /*eslint no-console: ["error", {allow: ["warn", "error"]}]*/
-                                console.error(error);
+                            } catch (error) {
+                                console.log(error);
                             }
                         }
                         vm.stopLoader();

diff --git a/gulpfile.js b/gulpfile.js
@@ -252,13 +252,19 @@ gulp.task('lint', [], function() {
         .pipe(eslint({}))
         .pipe(eslint.format())
         .pipe(eslint.results(function(results) {
-            connect.serverClose(); // Close the server initially.
-            var countError = results.errorCount; // Get the count of lint errors.
-            var countWarning = results.warningCount; // Get the count of lint warnings.
-            if (countError === 0) { // If there are no errors.
-                if (countWarning === 0) { // If there are no warnings.
-                    gulp.start('connect'); // Connect the server again.
+
+            // Get the count of lint errors 
+            var countError = results.errorCount;
+            //Get the count of lint warnings
+            var countWarning = results.warningCount;
+            if (countError === 0) {
+                gulp.start('connect');
+                if(countWarning > 0) {
+                    console.warn("Please remove lint warnings in production env.");
                 }
+            } else {
+                connect.serverClose();
+                console.error("Please remove lint errors to connect the server");
             }
         }))
 });
@@ -352,7 +358,9 @@ gulp.task('watch', function() {
 
 
 // Start a server for serving frontend
-gulp.task('connect', [], function() {
+gulp.task('connect', ['lint'], function() {
+    // initially close the existance server if exists
+    connect.serverClose();
     connect.server({
         root: 'frontend/',
         port: 8888,
@@ -390,5 +398,5 @@ gulp.task('prod', function(callback) {
 
 // Runserver for development
 gulp.task('dev:runserver', function(callback) {
-    runSequence('dev', 'watch', 'lint', callback);
+    runSequence('dev', 'connect', 'watch', callback);
 });