Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(richtext-lexical): link drawer has no fields if parent document create access control is false #10954

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

AlessioGr
Copy link
Member

@AlessioGr AlessioGr commented Feb 3, 2025

Previously, the lexical link drawer did not display any fields if the create permission was false, even though the update permission was true.

The issue was a faulty permission check in RenderFields that did not check the top-level permission operation keys for truthiness. It only checked if the permissions variable itself was true, or if the sub-fields had create / update permissions set to true.

@AlessioGr AlessioGr enabled auto-merge (squash) February 3, 2025 18:43
@AlessioGr AlessioGr merged commit 136c90c into main Feb 3, 2025
67 checks passed
@AlessioGr AlessioGr deleted the fix/lexical-drawer-permissions branch February 3, 2025 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant