feat(ui): timezone support on schedule publish #11086
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to UTC as it was invalid
paulpopus
requested review from
denolfe,
jmikrut and
DanRibbens
as code owners
paulpopus
requested review from
jacobsfletch,
AlessioGr and
JarrodMFlesch
as code owners
|
Closed in favour of #11090 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BASED ON #10896 (merge this one first)
This PR extends timezone support to scheduled publish UI and collection, the timezone will be stored on the
inputJSON instead of thewaitUntildate field so that we avoid needing a schema migration for SQL databases.If a timezone is selected then the displayed date in the table will be formatted for that timezone.
Timezones remain optional here as they can be deselected in which case the date will behave as normal, rendering and formatting to the user's local timezone.
For the backend logic that can be left untouched since the underlying date values are stored in UTC the job runners will always handle this relative time by default.
Todo: