Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(db-postgres): Add multiple field sort by string #6129

Closed
wants to merge 7 commits into from

Conversation

SimYunSup
Copy link
Contributor

Description

Related disscusion is #2089. For 1.x PR, #3236.

I added conditional logic for multiple field sort. sort string is implemented as comma format like PR comment.

if (orderBy.column) {
selectFields.sort = orderBy.column
}

I wasn't sure what this code was doing, so I opened the PR as a draft.

  • I have read and understand the CONTRIBUTING.md document in this repository.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have added tests that prove my fix is effective or that my feature works
  • Existing test suite passes locally with my changes
  • I have made corresponding changes to the documentation

@SimYunSup SimYunSup force-pushed the feature/#2089 branch 2 times, most recently from bf4cd58 to 07ab50e Compare May 22, 2024 08:48
@SimYunSup SimYunSup changed the title feat(db): Add multiple field sort by string feat(db-postgres): Add multiple field sort by string May 22, 2024
@SimYunSup
Copy link
Contributor Author

Progress: Fix adding version. to sortPath when queryDraft has sort.

When payload v3 is released, I hope it will be fixed and merged with the reason why selectFields.sort was used. :)

@max-degterev
Copy link

any chance to get this updated/merged?

@max-degterev
Copy link

guys?

@SimYunSup
Copy link
Contributor Author

@max-degterev I'm not working on payload at the moment, so I apologize for the slow response. It will take a while for me to get back to updating this PR to the latest commit.

@r1tsuu
Copy link
Member

r1tsuu commented Oct 24, 2024

This was implemented here #8799 and will be in the next release, closing this old one, thanks for the attempt!.

@r1tsuu r1tsuu closed this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants