fix: join field works on collections with versions enabled #8715
Conversation
r1tsuu
force-pushed
the
fix/join-field-does-not-work-when-versions-are-enabled-this-branch-should-fix-that
branch
from
f5bdb79
to
44d578e
Compare
r1tsuu
force-pushed
the
fix/join-field-does-not-work-when-versions-are-enabled-this-branch-should-fix-that
branch
from
b5533f0
to
9434429
Compare
| @@ -74,6 +74,7 @@ export const init: Init = async function init(this: BasePostgresAdapter) { | |||
| disableNotNull: !!collection.versions?.drafts, | |||
| disableUnique: true, | |||
| fields: versionFields, | |||
| joins: collection.joins, | |||
There was a problem hiding this comment.
Is this being used any longer since you deleted the case 'join' field in traverseFields?
| @@ -936,30 +936,6 @@ export const traverseFields = ({ | |||
|
|
|||
| break | |||
|
|
|||
| case 'join': { | |||
There was a problem hiding this comment.
Even if we are not using the relationship any more, I'm wondering if it isn't good to keep just for somebody who might want to do their own drizzle queries later.
There was a problem hiding this comment.
Since we have the afterSchemaInit thing (which includes schema.relationships), they can add their relationships there as they would like. I also feel like we should have some nice drizzle types generation, as for now it's not easy to use those.
Currently, even with using the introspection feature, relationships won't appear because those aren't defined in the database, not sure how we can solve this nicely
joinstodb.queryDraftsto have them when doing.findwithdraft: true