-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes for adding additional information for invalid status in log #379
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need the "or" operator because it is valid scenario that status changes but status time remains. It may be necessary to have respective checks (if condition) for time and status.
Reverted the condition and added status check for the latest row data. This stop trigger RACMAINT_INFO_CHANGE for status 'U'. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, please consider to add test that valid instruction status (R, F) to U.
The Java CI failure could be from tests/devdocker [5/6] RUN go get github.com/go-sql-driver/mysql I've made #381 to try to fix it |
The earlier condition was RAC data tm(time value in millis) change or status change we allow proceed. Now, the code has changed with the "and" condition because if there is no change in status and TM then we can skip RAC_MAINT_CHANGE event.