Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes for adding additional information for invalid status in log #379

Merged
merged 6 commits into from
Jan 3, 2024

Conversation

rasamala83
Copy link
Collaborator

The earlier condition was RAC data tm(time value in millis) change or status change we allow proceed. Now, the code has changed with the "and" condition because if there is no change in status and TM then we can skip RAC_MAINT_CHANGE event.

Copy link
Collaborator

@shtiencode shtiencode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need the "or" operator because it is valid scenario that status changes but status time remains. It may be necessary to have respective checks (if condition) for time and status.

@rasamala83
Copy link
Collaborator Author

I think we need the "or" operator because it is valid scenario that status changes but status time remains. It may be necessary to have respective checks (if condition) for time and status.

Reverted the condition and added status check for the latest row data. This stop trigger RACMAINT_INFO_CHANGE for status 'U'.

Copy link
Collaborator

@shtiencode shtiencode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please consider to add test that valid instruction status (R, F) to U.

@ModEtchFill
Copy link
Contributor

The Java CI failure could be from tests/devdocker

[5/6] RUN go get github.com/go-sql-driver/mysql
18:53:45.248 [main] DEBUG com.paypal.hera.jdbc.UtilHeraBox - #10 1.282 # filippo.io/edwards25519
Error: 18:53:45.248 [main] DEBUG com.paypal.hera.jdbc.UtilHeraBox - #10 1.282 src/filippo.io/edwards25519/scalar.go:166:53: cannot convert x (type []byte) to type *[32]byte

I've made #381 to try to fix it

tests/unittest/rac_maint/main_test.go Outdated Show resolved Hide resolved
tests/unittest/rac_maint/main_test.go Show resolved Hide resolved
@rasamala83 rasamala83 merged commit 84dc20c into paypal:main Jan 3, 2024
5 of 6 checks passed
@rasamala83 rasamala83 deleted the improve_cal_for_rac_maint branch January 3, 2024 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants