Venmo overlay #2271
Merged
Venmo overlay #2271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsbrunson
approved these changes
Nov 6, 2023
nbierdeman
force-pushed
the
venmo-overlay
branch
from
61eda6d to
5d0adf2
Compare
nikrom17
approved these changes
Nov 7, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2271 +/- ##
==========================================
+ Coverage 51.01% 51.18% +0.16%
==========================================
Files 104 104
Lines 2025 2032 +7
Branches 599 601 +2
==========================================
+ Hits 1033 1040 +7
Misses 889 889
Partials 103 103
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a Venmo overlay component as requested in DTPPCPSDK-1254. It will be used for all Venmo button clicks, including Venmo Web use cases. The goal was to mimic the look and behavior of the BT SDK Venmo overlay in the PP SDK.
It was decided by Product that we should hard code English for now (English is currently the only language supported by Venmo), and that we should completely separate styles despite there being some duplication with the PayPal overlay.
Screenshots
Here's a video demonstrating switching between the PayPal and Venmo overlays, including still displaying English in the Venmo overlay after setting the browser language (i.e.
navigator.language) to Spanish:Screen.Recording.2023-11-03.at.12.42.16.PM.mov
Dependent Changes
paypal/paypal-common-components#84 needs to be merged and published first.