Fix for firefox hover/filter side-effect #2274
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Firefox displays a weird side-effect when hovering and applying
filter: brightness(X)
(the element being hovered loses its shape). The root cause of this could be many things (there are a lot of classes being applied to paypal-button). We observed thatoverflow: hidden
was having some cascading side-effect onfilter: brightness(X)
. The proposed solution is to explicitly applyoverflow: inherit
to the hover class. This solution targets the.paypal-button.paypal-button-color-{COLOR}:hover
only and thus prevents this to cascade onto any other classes. This fixes the bug in firefox and the behavior remains the same in chrome.eg:
.paypal-button.paypal-button-color-{COLOR}:hover { filter: brightness(X); overflow: inherit; }
Why are we making these changes? Include references to any related Jira tasks or GitHub Issues
Ticket LI-26326 pointed out weird behavior when hovering PayPal button in Firefox.
Reproduction Steps (if applicable)
Go to this codepen (fyi: reproduction is not consistent on all devices)
Screenshots (if applicable)
Unhovered button:
Hovered button:
Dependent Changes (if applicable)
Groups who should review (if applicable)
❤️ Thank you!