New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ternary_value_flag feature without tests #56

Open

shivang2056yadav wants to merge 1 commit into pboling:master from payu-intrepos:feature/ternary_flag

shivang2056yadav commented Oct 12, 2016

No description provided.

coveralls commented Oct 12, 2016

Coverage decreased (-2.9%) to 44.0% when pulling c17f979 on payu-intrepos:feature/ternary_flag into c28a287 on pboling:master.

1 similar comment

coveralls commented Oct 12, 2016 •

edited

Loading

Coverage decreased (-2.9%) to 44.0% when pulling c17f979 on payu-intrepos:feature/ternary_flag into c28a287 on pboling:master.

shivang2056yadav force-pushed the feature/ternary_flag branch 2 times, most recently from 2152d95 to cad429c Compare

October 13, 2016 05:11

coveralls commented Oct 13, 2016 •

edited

Loading

Coverage decreased (-46.9%) to 0.0% when pulling 2152d95 on payu-intrepos:feature/ternary_flag into c28a287 on pboling:master.

2 similar comments

coveralls commented Oct 13, 2016

Coverage decreased (-46.9%) to 0.0% when pulling 2152d95 on payu-intrepos:feature/ternary_flag into c28a287 on pboling:master.

coveralls commented Oct 13, 2016 •

edited

Loading

Coverage decreased (-46.9%) to 0.0% when pulling 2152d95 on payu-intrepos:feature/ternary_flag into c28a287 on pboling:master.

shivang2056yadav force-pushed the feature/ternary_flag branch from cad429c to def53dc Compare

October 13, 2016 05:19

coveralls commented Oct 13, 2016 •

edited

Loading

Coverage decreased (-3.5%) to 43.369% when pulling cad429c on payu-intrepos:feature/ternary_flag into c28a287 on pboling:master.

coveralls commented Oct 13, 2016 •

edited

Loading

Coverage decreased (-3.5%) to 43.369% when pulling def53dc on payu-intrepos:feature/ternary_flag into c28a287 on pboling:master.

1 similar comment

coveralls commented Oct 13, 2016

Coverage decreased (-3.5%) to 43.369% when pulling def53dc on payu-intrepos:feature/ternary_flag into c28a287 on pboling:master.

shivang2056yadav force-pushed the feature/ternary_flag branch from def53dc to 6a6e5e4 Compare

October 13, 2016 05:30

coveralls commented Oct 13, 2016 •

edited

Loading

Coverage decreased (-3.5%) to 43.369% when pulling 6a6e5e4 on payu-intrepos:feature/ternary_flag into c28a287 on pboling:master.

shivang2056yadav force-pushed the feature/ternary_flag branch 2 times, most recently from ef9b61b to fe9a2f4 Compare

October 13, 2016 06:18

coveralls commented Oct 13, 2016 •

edited

Loading

Coverage decreased (-3.5%) to 43.369% when pulling ef9b61b on payu-intrepos:feature/ternary_flag into c28a287 on pboling:master.

1 similar comment

coveralls commented Oct 13, 2016

Coverage decreased (-3.5%) to 43.369% when pulling ef9b61b on payu-intrepos:feature/ternary_flag into c28a287 on pboling:master.

shivang2056yadav force-pushed the feature/ternary_flag branch from 8cd92ea to d8d120f Compare

October 13, 2016 06:36

coveralls commented Oct 13, 2016 •

edited

Loading

Coverage decreased (-3.5%) to 43.369% when pulling 8cd92ea on payu-intrepos:feature/ternary_flag into c28a287 on pboling:master.

6 similar comments

coveralls commented Oct 13, 2016

Coverage decreased (-3.5%) to 43.369% when pulling 8cd92ea on payu-intrepos:feature/ternary_flag into c28a287 on pboling:master.

coveralls commented Oct 13, 2016

Coverage decreased (-3.5%) to 43.369% when pulling 8cd92ea on payu-intrepos:feature/ternary_flag into c28a287 on pboling:master.

coveralls commented Oct 13, 2016

Coverage decreased (-3.5%) to 43.369% when pulling 8cd92ea on payu-intrepos:feature/ternary_flag into c28a287 on pboling:master.

coveralls commented Oct 13, 2016

Coverage decreased (-3.5%) to 43.369% when pulling 8cd92ea on payu-intrepos:feature/ternary_flag into c28a287 on pboling:master.

coveralls commented Oct 13, 2016

Coverage decreased (-3.5%) to 43.369% when pulling 8cd92ea on payu-intrepos:feature/ternary_flag into c28a287 on pboling:master.

coveralls commented Oct 13, 2016

Coverage decreased (-3.5%) to 43.369% when pulling 8cd92ea on payu-intrepos:feature/ternary_flag into c28a287 on pboling:master.

coveralls commented Oct 13, 2016 •

edited

Loading

Coverage decreased (-3.5%) to 43.369% when pulling d8d120f on payu-intrepos:feature/ternary_flag into c28a287 on pboling:master.

1 similar comment

coveralls commented Oct 13, 2016

Coverage decreased (-3.5%) to 43.369% when pulling d8d120f on payu-intrepos:feature/ternary_flag into c28a287 on pboling:master.

coveralls commented Oct 13, 2016 •

edited

Loading

Coverage decreased (-3.5%) to 43.369% when pulling d8d120f on payu-intrepos:feature/ternary_flag into c28a287 on pboling:master.

coveralls commented Oct 13, 2016 •

edited

Loading

Coverage decreased (-3.5%) to 43.369% when pulling d8d120f on payu-intrepos:feature/ternary_flag into c28a287 on pboling:master.

1 similar comment

coveralls commented Oct 13, 2016

Coverage decreased (-3.5%) to 43.369% when pulling d8d120f on payu-intrepos:feature/ternary_flag into c28a287 on pboling:master.

coveralls commented Oct 13, 2016

Coverage decreased (-3.5%) to 43.369% when pulling d8d120f on payu-intrepos:feature/ternary_flag into c28a287 on pboling:master.

shivang2056yadav force-pushed the feature/ternary_flag branch from d8d120f to d655c4f Compare

October 13, 2016 10:23

houndci-bot reviewed

View reviewed changes

lib/flag_shih_tzu.rb

    
                    collect_flags(*flags_to_collect) do |memo, flag|

                      memo << "not_#{flag}".to_sym unless truthy_and_chosen.include?(flag)

                      memo << "nil_#{flag}".to_sym if self.send(flag) == false

Collaborator

houndci-bot Oct 13, 2016

Redundant self detected.

houndci-bot reviewed

View reviewed changes

lib/flag_shih_tzu.rb

-                  truthy_and_chosen.concat(
+                  untruthy_and_unchosen = (
+                  collect_flags(*flags_to_collect) do |memo, flag|
+                    memo << "not_#{flag}".to_sym if self.send(flag) == false

Collaborator

houndci-bot Oct 13, 2016

Redundant self detected.

houndci-bot reviewed

View reviewed changes

lib/flag_shih_tzu.rb

@@ @@ -18,6 +21,7 @@ def self.included(base) @@
                 class IncorrectFlagColumnException < Exception; end
                 class NoSuchFlagQueryModeException < Exception; end
                 class NoSuchFlagException < Exception; end
+                class InvalidValueForFlagException < Exception; end

Collaborator

houndci-bot Oct 13, 2016

Inherit from RuntimeError instead of Exception.

Owner

pboling Oct 17, 2016

Yeah, all of these classes should not be inheriting from Exception. 💯 Needs to be fixed.

coveralls commented Oct 13, 2016 •

edited

Loading

Coverage decreased (-3.5%) to 43.369% when pulling d655c4f on payu-intrepos:feature/ternary_flag into c28a287 on pboling:master.

Owner

pboling commented Oct 14, 2016

@shivang2056yadav - wow! This is really cool! I need to spend more time looking over it.

pboling self-assigned this

pboling added enhancement in progress labels


          ternary_value_flag feature without tests

4b19eef

shivang2056yadav force-pushed the feature/ternary_flag branch from d655c4f to 4b19eef Compare

October 17, 2016 08:33

coveralls commented Oct 17, 2016 •

edited

Loading

Coverage decreased (-3.5%) to 43.369% when pulling 4b19eef on payu-intrepos:feature/ternary_flag into c28a287 on pboling:master.

Owner

pboling commented Apr 29, 2017

Needs to be rebased on latest master, which now has a passing build on Travis.

pboling added this to the 0.4 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement in progress