Dominion #94
Merged
Dominion #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsheehan-SF-RLA
added a commit
to bsheehan-SF-RLA/SHANGRLA
that referenced
this pull request
Nov 14, 2024
Dominion (pbstark#94)
pbstark
added a commit
that referenced
this pull request
Nov 28, 2024
* Oneaudit (#92) * WIP: improving Dominion support, progress towards ONEAudit integration * WIP: Dominion tools * Dominion "multiple card" fix, Testcase Regression Fixes (#91) * This commit fixes issues with the record_id not always set, and the use_current flag never being used * Fix earlier issue where only the first 'Card' in the Dominion output was parsed, added associated unit tests --------- Co-authored-by: Philip B. Stark <[email protected]> * WIP: ONEAudit integration. Dominion mvr retrieval improvements * WIP: Dominion card numbering, construct pool_means only for pool==True CVRs * WIP: working but sample size estimation needs to be improved * ENH: ONEAudit seems to be working, including sample size estimation. * ENH: improve documentation in ONEAudit notebook; minor bug fixes --------- Co-authored-by: bsheehan-SF-RLA <[email protected]> * Added missing parameter in supermajority assertion and changed np.infty (no longer supported) to np.inf (#93) * Dominion (#94) * BUG: change logic for parsing Dominion ranks, fix minor bugs in supermajority * BUG: revise unit test for Dominion to match new mark processing * ENH: logic for SF treatment of multiple ranks assigned to same candidate in IRV * ENH: logic for SF treatment of multiple ranks assigned to same candidate in IRV * ENH: logic for SF treatment of multiple ranks assigned to same candidate in IRV * ENH: logic for SF treatment of multiple ranks assigned to same candidate in IRV * Optimizations for Dominion.sample_from_cvrs and CVR.consistent_sampling (#95) * Speed optimizations for Dominion.sample_from_cvrs() and CVR.consistent_sampling() * Unit tests for optimzations in last commit, should pass on original and optimized code --------- Co-authored-by: bsheehan-SF-RLA <[email protected]> Co-authored-by: Alexander Ek <[email protected]>
pbstark
added a commit
that referenced
this pull request
Nov 28, 2024
* WIP: improving Dominion support, progress towards ONEAudit integration * WIP: Dominion tools * Dominion "multiple card" fix, Testcase Regression Fixes (#91) * This commit fixes issues with the record_id not always set, and the use_current flag never being used * Fix earlier issue where only the first 'Card' in the Dominion output was parsed, added associated unit tests --------- Co-authored-by: Philip B. Stark <[email protected]> * WIP: ONEAudit integration. Dominion mvr retrieval improvements * WIP: Dominion card numbering, construct pool_means only for pool==True CVRs * WIP: working but sample size estimation needs to be improved * ENH: ONEAudit seems to be working, including sample size estimation. * ENH: improve documentation in ONEAudit notebook; minor bug fixes * improving ability to test sample sizes (#97) * Oneaudit (#92) * WIP: improving Dominion support, progress towards ONEAudit integration * WIP: Dominion tools * Dominion "multiple card" fix, Testcase Regression Fixes (#91) * This commit fixes issues with the record_id not always set, and the use_current flag never being used * Fix earlier issue where only the first 'Card' in the Dominion output was parsed, added associated unit tests --------- Co-authored-by: Philip B. Stark <[email protected]> * WIP: ONEAudit integration. Dominion mvr retrieval improvements * WIP: Dominion card numbering, construct pool_means only for pool==True CVRs * WIP: working but sample size estimation needs to be improved * ENH: ONEAudit seems to be working, including sample size estimation. * ENH: improve documentation in ONEAudit notebook; minor bug fixes --------- Co-authored-by: bsheehan-SF-RLA <[email protected]> * Added missing parameter in supermajority assertion and changed np.infty (no longer supported) to np.inf (#93) * Dominion (#94) * BUG: change logic for parsing Dominion ranks, fix minor bugs in supermajority * BUG: revise unit test for Dominion to match new mark processing * ENH: logic for SF treatment of multiple ranks assigned to same candidate in IRV * ENH: logic for SF treatment of multiple ranks assigned to same candidate in IRV * ENH: logic for SF treatment of multiple ranks assigned to same candidate in IRV * ENH: logic for SF treatment of multiple ranks assigned to same candidate in IRV * Optimizations for Dominion.sample_from_cvrs and CVR.consistent_sampling (#95) * Speed optimizations for Dominion.sample_from_cvrs() and CVR.consistent_sampling() * Unit tests for optimzations in last commit, should pass on original and optimized code --------- Co-authored-by: bsheehan-SF-RLA <[email protected]> Co-authored-by: Alexander Ek <[email protected]> --------- Co-authored-by: bsheehan-SF-RLA <[email protected]> Co-authored-by: Alexander Ek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update formats.Dominion.read_cvrs() to handle mis-marked RCV ballots according to local San Francisco rules, including keeping only the lowest rank a CVR assigns to a candidate if more than one rank is given. Also minor bug fixes.