Add unit tests for bobbit.history #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbui
reviewed
Oct 4, 2020
|
@shawalli Besides the in-place reverse, everything else looks OK. Go ahead and revert that and I'll test it out. Thanks. |
|
The original implementation was throwing an error when I ran it, that's why
I changed it. Would you want me to copy the deque and reverse that? Or
perform the for loop in reverse order?
…On Sun, Oct 4, 2020, 4:43 PM Peter Bui ***@***.***> wrote:
@shawalli <https://github.com/shawalli> Besides the in-place reverse,
everything else looks OK. Go ahead and revert that and I'll test it out.
Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAW4KLREEORSW24DSO2RYQLSJDNAXANCNFSM4SD5EG4A>
.
|
|
I think we should do: |
pbui
reviewed
Oct 4, 2020
Add script runner to history test
|
@shawalli Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for
bobbit.history. Addresses task in #17.