Add unit tests for bobbit.message #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbui
reviewed
Oct 6, 2020
pbui
reviewed
Oct 7, 2020
|
@shawalli Once again, thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit tests for bobbit.message. Addresses task in #17.
Regarding the boolean change -- In python
not valuesinclude a variety of things, such as 0, empty strings, empty dicts, empty lists,False,None, and more, I'm sure. As originally written, bothFalseandNonearguments would cause thecopylogic to defer to the original Message's value, instead of justNonearguments. Thecopycode was updated to explicitly check forNone. It would also make sense to update these checks for empty strings, however, I'm assuming the code wouldn't normally pass emptynicks,channels, etc.