FIX: The Arbiter fault on behalf of qrix is now auto reset. #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…have to reset only the actual faults on qrix, when those are cleared this summary fault clears as well.
ZLLentz
reviewed
Jun 4, 2024
Arbiter/KFEArbiter/LineIDs.dbg
Outdated
There was a problem hiding this comment.
.dbg files shouldn't be committed, this repo's gitignore is old: https://confluence.slac.stanford.edu/display/PCDS/TwinCAT+3+Git+Setup+and+Best+Practices#TwinCAT3GitSetupandBestPractices-.gitignore
ZLLentz
reviewed
Jun 4, 2024
| @@ -51,6 +51,7 @@ | |||
| <SyncUnit Name="tmo" NoDeleteIfUnused="true"/> | |||
| <SyncUnit Name="crix" NoDeleteIfUnused="true"/> | |||
| <SyncUnit Name="qrix" NoDeleteIfUnused="true"/> | |||
| <SyncUnit Name="future" NoDeleteIfUnused="true"/> | |||
There was a problem hiding this comment.
This isn't causing a problem, but what is this? Can we document what it is in this PR?
There was a problem hiding this comment.
@ghalym we should document what this is for in the PR description
ZLLentz
previously approved these changes
Jun 4, 2024
Thank you. I fixed the gitignore file and ran pre-commit. |
ZLLentz
reviewed
Jun 5, 2024
ZLLentz
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Arbiter fault on behalf of qrix is now auto reset. The user have to reset only the actual faults on qrix, when those are cleared this summary fault clears as well.
Description
Motivation and Context
How Has This Been Tested?
Where Has This Been Documented?
Screenshots (if appropriate):
Pre-merge checklist
Always Newestpre-commit(alternativelypre-commit run --all-files)