Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using different veto arbiter for K3, adding MR1K3 IN as a veto for K4 #131

Closed
wants to merge 1 commit into from

Conversation

KaushikMalapati
Copy link
Contributor

Description

Adding a separate veto arbiter for K3 devices that uses fast fault output three
Adding a new veto condition for K4 devices when MR1K3 is IN

Motivation and Context

Meant to close #130
https://jira.slac.stanford.edu/browse/ECS-6866
https://jira.slac.stanford.edu/browse/ECS-5642

How Has This Been Tested?

N/A

Where Has This Been Documented?

N/A

Screenshots (if appropriate):

Pre-merge checklist

  • Code works interactively
  • Code contains descriptive comments
  • Test suite passes locally
  • Libraries are set to fixed versions and not Always Newest
  • Code committed with pre-commit (alternatively pre-commit run --all-files)

Copy link
Contributor

@tongju12 tongju12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KaushikMalapati
Copy link
Contributor Author

Opened a new pull request to avoid merge conflict in xti

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Veto arbiter fault downstream of MR1K3
2 participants