Integrating pf1k0 ppm #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshc-slac
force-pushed
the
integrating-pf1k0-ppm
branch
from
1bcf262 to
48a2dea
Compare
|
Can you check the boxes if this has been tested? |
|
Seems OK |
Yes. It was expected, the limit switch cable is only being integrated tomorrow during the access. |
joshc-slac
force-pushed
the
integrating-pf1k0-ppm
branch
from
48a2dea to
7094ceb
Compare
|
Do you want a final review now, or wait until the install is finished? |
|
It is finished. Trying to rush for Maggie and Kaushik to test during their window as they want to work off of master. |
ghalym
approved these changes
Feb 25, 2025
| @@ -156,6 +159,10 @@ | |||
| <DefaultResolution>Tc3_Module, * (Beckhoff Automation GmbH)</DefaultResolution> | |||
| <Namespace>Tc3_Module</Namespace> | |||
| </PlaceholderReference> | |||
| <PlaceholderReference Include="TcUnit"> | |||
| <DefaultResolution>TcUnit, * (www.tcunit.org)</DefaultResolution> | |||
There was a problem hiding this comment.
All libraries need to be tagged with a version number
There was a problem hiding this comment.
Strangely, this is tagged below in the same file as 1.2.0.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created the PF1K0_PM POU which integrates a FB_PPM_PowerMeter and a FB_MPA (motion pneumatic actuator?) to actuate and read from the newly installed power meter at PF1K0
Motivation and Context
We can succesfully read from and actuate new device. However we will only get limit switch cable integrated during the access on 2/26.
How Has This Been Tested?
On the system. Still and extant worry about interfacing with PMPS things generally
Where Has This Been Documented?
Screenshots (if appropriate):
Pre-merge checklist
Always Newestpre-commit(alternativelypre-commit run --all-files)